Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chart: add chart name and version to the operator deployment (#694) #720

Merged

Conversation

davidcassany
Copy link
Contributor

@davidcassany davidcassany commented May 6, 2024

Re-adding this commit as those labels are part of the recommended labels for a deployment resource. So even if in the future this is not a strict requirement from the UI I think it is a good practice to keep them.

This also keeps backward compatibility, relevant for rancher/elemental-ui#178

…#694)

Fixes rancher#691

Signed-off-by: Francesco Giudici <francesco.giudici@suse.com>
@davidcassany davidcassany requested a review from a team as a code owner May 6, 2024 11:27
Copy link
Contributor

@anmazzotti anmazzotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@davidcassany davidcassany merged commit aff1e2c into rancher:v1.6.x May 6, 2024
8 of 9 checks passed
@davidcassany davidcassany deleted the readd_deplyment_labels_to_1.6 branch May 6, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants