Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include elemental-operator version into an annotation in elemental-operator deployment resource #691

Closed
davidcassany opened this issue Mar 22, 2024 · 1 comment · Fixed by #694
Closed

Include elemental-operator version into an annotation in elemental-operator deployment resource #691

davidcassany opened this issue Mar 22, 2024 · 1 comment · Fixed by #694
Assignees
@fgiudici
Labels
kind/enhancement New feature or request
Milestone
Micro6

Comments

@davidcassany
Copy link
Contributor

The idea is to include the elemental-operator version in an annotation within the deployment. This will easily allow the UI to actually react according to the elemental-operator version.

With @aalves08 we agreed to map features to versions in UI, hence if the elemental-operator is not in the version including certain feature this will not show up in the UI.

Currently for elemental-operator v1.5.x we included a couple of features impacting UI:

  • Raw disk images can only be built using the UI starting from elemental-operator v1.5.x
  • The machine registration defaults in latest UI RC are only supported for v1.5.x and onwards. Basically the snapshotter related defaults. On previous versions the defaults should not include the snapshotter field.
@davidcassany davidcassany added the kind/enhancement New feature or request label Mar 22, 2024
@davidcassany davidcassany added this to the Micro6 milestone Mar 22, 2024
@aalves08 aalves08 mentioned this issue Mar 27, 2024
Closed
@fgiudici fgiudici self-assigned this Apr 2, 2024
@fgiudici fgiudici mentioned this issue Apr 2, 2024
Merged
@fgiudici
Copy link
Member

fgiudici commented Apr 2, 2024

The idea is to use the Kubernetes recommended labels for the deployment resource

fgiudici added a commit that referenced this issue Apr 2, 2024
@fgiudici
chart: add chart name and version to the operator deployment (#694)
f965445 
Fixes #691

Signed-off-by: Francesco Giudici <francesco.giudici@suse.com>
@fgiudici fgiudici mentioned this issue Apr 4, 2024
Merged
@aalves08 aalves08 mentioned this issue Apr 23, 2024
Merged
davidcassany pushed a commit to davidcassany/elemental-operator that referenced this issue May 6, 2024
@fgiudici @davidcassany
chart: add chart name and version to the operator deployment (rancher…
1a9ea35 
…#694)

Fixes rancher#691

Signed-off-by: Francesco Giudici <francesco.giudici@suse.com>
@davidcassany davidcassany mentioned this issue May 6, 2024
Merged
davidcassany pushed a commit to davidcassany/elemental-operator that referenced this issue May 6, 2024
@fgiudici @davidcassany
chart: add chart name and version to the operator deployment (rancher…
7b4dbb5 
…#694)

Fixes rancher#691

Signed-off-by: Francesco Giudici <francesco.giudici@suse.com>
davidcassany pushed a commit that referenced this issue May 6, 2024
@fgiudici @davidcassany
chart: add chart name and version to the operator deployment (#694)
ca0ed22 
Fixes #691

Signed-off-by: Francesco Giudici <francesco.giudici@suse.com>
davidcassany pushed a commit that referenced this issue May 6, 2024
@fgiudici @davidcassany
chart: add chart name and version to the operator deployment (#694)
aff1e2c 
Fixes #691

Signed-off-by: Francesco Giudici <francesco.giudici@suse.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fgiudici fgiudici

Labels
kind/enhancement New feature or request
Projects
Elemental
Archived in project
Milestone
Micro6
Development

Successfully merging a pull request may close this issue.

chart: add chart name and version to the operator deployment fgiudici/elemental-operator
2 participants
@davidcassany @fgiudici