-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the fetching of fundamentals #480
Conversation
Thank you. Your fix solved the isuee. Would be great to have it in the next release. |
So when is next release, because I change it by hand, and this bug blocking useful informations. |
This PR works great, I am not sure why it isn't merged yet. |
I am still facing this issue. When will it be fixed in the next release. Thank you. |
Ya, I am facing the same issue. |
can you merge this MR? it's commited in October |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed the problem for me
As of now, the fetching of fundamentals is broken for some (all?) tickers (e.g. BIM.PA, AF.PA, IBM, etc.).
The reason for that is located in the
_get_fundamentals
method implemented inbase.py
, between the lines 280 and 285: theurl
var (containing the base_url and the ticker) has "/holders" appended, and when fetching the fundamentals, only "/financials" is appended again, instead of replacing "/holders".This PR fixes the issue.
Before:
After: