Merge pull request #480 from PaulRenvoise/fix/fundamentals

Fix the fetching of fundamentals
ranaroussi · Jan 18, 2021 · a72557b · a72557b
2 parents 58b3eaf + e28283a
commit a72557b
Showing 1 changed file with 8 additions and 8 deletions.
diff --git a/yfinance/base.py b/yfinance/base.py
@@ -276,14 +276,14 @@ def cleanup(data):
         if self._fundamentals:
             return
 
+        ticker_url = "{}/{}".format(self._scrape_url, self.ticker)
+
         # get info and sustainability
-        url = '%s/%s' % (self._scrape_url, self.ticker)
-        data = utils.get_json(url, proxy)
+        data = utils.get_json(ticker_url, proxy)
 
         # holders
-        url = "{}/{}/holders".format(self._scrape_url, self.ticker)
-        holders = _pd.read_html(url)
-
+        holders = _pd.read_html(ticker_url+'/holders')
+
         if len(holders)>=3:
             self._major_holders = holders[0]
             self._institutional_holders = holders[1]
@@ -293,10 +293,10 @@ def cleanup(data):
             self._institutional_holders = holders[1]
         else:
             self._major_holders = holders[0]
-        
+
         #self._major_holders = holders[0]
         #self._institutional_holders = holders[1]
-        
+
         if self._institutional_holders is not None:
             if 'Date Reported' in self._institutional_holders:
                 self._institutional_holders['Date Reported'] = _pd.to_datetime(
@@ -373,7 +373,7 @@ def cleanup(data):
             pass
 
         # get fundamentals
-        data = utils.get_json(url+'/financials', proxy)
+        data = utils.get_json(ticker_url+'/financials', proxy)
 
         # generic patterns
         for key in (