Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update node version on CI to 20 #286

Merged
merged 5 commits into from
Nov 3, 2023
Merged

Update node version on CI to 20 #286

merged 5 commits into from
Nov 3, 2023

Conversation

louise-davies
Copy link
Member

Description

See title

Testing instructions

Add a set up instructions describing how the reviewer should test the code

  • Review code
  • Check Actions build
  • Review changes to test coverage

@louise-davies louise-davies requested a review from kaperoo November 2, 2023 16:22
@louise-davies
Copy link
Member Author

Probably need to fix #158 first

Copy link

codecov bot commented Nov 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7f47a97) 95.23% compared to head (8590cbd) 95.23%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #286   +/-   ##
========================================
  Coverage    95.23%   95.23%           
========================================
  Files           76       76           
  Lines         3481     3481           
  Branches       964      964           
========================================
  Hits          3315     3315           
  Misses         164      164           
  Partials         2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

kaperoo
kaperoo previously approved these changes Nov 3, 2023
Copy link
Contributor

@kaperoo kaperoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@louise-davies louise-davies merged commit 4d1afe6 into develop Nov 3, 2023
4 checks passed
@louise-davies louise-davies deleted the update-node-CI branch November 3, 2023 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants