Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSEGOG-33 Upgrading to Cypress v12 #158

Merged
merged 4 commits into from
Nov 3, 2023
Merged

Conversation

sam-glendenning
Copy link
Contributor

Description

Updates from current version v9.7.0.

Testing instructions

v9.7.0 should be gone and v12.0.2 in its place.

  • Review code
  • Check Actions build
  • Review changes to test coverage

Agile board tracking

Closes DSEGOG-33

Currently getting an error still to be investigated
@sam-glendenning sam-glendenning changed the base branch from develop to DSEGOG-207-authorisation December 12, 2022 14:35
@sam-glendenning
Copy link
Contributor Author

sam-glendenning commented Dec 12, 2022

@louise-davies I know this was an issue assigned to you but I thought I'd tackle it since I had a bit of time before lunch today. It hasn't gone exactly to plan as you can see from the error message reported by Cypress.

image

I have looked through a variety of threads to try and understand the problem here and come up empty-handed when trying various solutions (plus I'd rather move onto another issue since this upgrade isn't too pressing) so I thought I'd leave this PR here for you to pick up if you want to build upon it if you find a fix (or I can finish what I've started).

I will link some threads I looked through below in case they are of use. Because I didn't see this error appear on the upgrade to Cypress 10 and beyond in SciGateway and DataGateway, I suspect Yarn plug-n-play and/or zero install are involved in this in some way and Cypress can't quite find what it's looking for (whether that be Typescript, the Cypress module itself or something else). I'm also fairly sure that the provided error message is closer to a red herring than an indication of what the actual problem might be.

https://stackoverflow.com/questions/73221655/unknown-file-extension-ts-cypress-config-ts-on-ci
cypress-io/cypress#22096
cypress-io/cypress#22747

@sam-glendenning
Copy link
Contributor Author

Also the base branch for this is currently the auth branch (for testing purposes) but I never got that far so we'll have to make sure it's changed back to develop after that's merged

Base automatically changed from DSEGOG-207-authorisation to develop December 13, 2022 10:08
@louise-davies
Copy link
Member

@sam-glendenning looks like the last issue you referenced seems like the likely culprit as they admit that TS based cypress config is not working with PnP. Since the upgrade isn't urgent, I will subscribe to that issue to keep tabs on it and look back into this once it's resolved

@sam-glendenning sam-glendenning marked this pull request as draft December 15, 2022 16:15
@codecov
Copy link

codecov bot commented Dec 16, 2022

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (3c47734) 95.20% compared to head (13a2f26) 95.20%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #158   +/-   ##
========================================
  Coverage    95.20%   95.20%           
========================================
  Files           76       76           
  Lines         3481     3481           
  Branches       964      964           
========================================
  Hits          3314     3314           
  Misses         165      165           
  Partials         2        2           
Files Coverage Δ
src/index.tsx 46.06% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@louise-davies louise-davies mentioned this pull request Nov 2, 2023
3 tasks
@louise-davies louise-davies marked this pull request as ready for review November 3, 2023 09:54
Copy link
Member

@louise-davies louise-davies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works both locally and on CI - just had to use a specific version that works nicely with Yarn PnP and not use a ts config file and instead use a CJS js config file

@louise-davies louise-davies merged commit 96fd1ee into develop Nov 3, 2023
3 of 4 checks passed
@louise-davies louise-davies deleted the DSEGOG-33-cypress-v12 branch November 3, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants