-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DSEGOG-33 Upgrading to Cypress v12 #158
Conversation
Currently getting an error still to be investigated
@louise-davies I know this was an issue assigned to you but I thought I'd tackle it since I had a bit of time before lunch today. It hasn't gone exactly to plan as you can see from the error message reported by Cypress. I have looked through a variety of threads to try and understand the problem here and come up empty-handed when trying various solutions (plus I'd rather move onto another issue since this upgrade isn't too pressing) so I thought I'd leave this PR here for you to pick up if you want to build upon it if you find a fix (or I can finish what I've started). I will link some threads I looked through below in case they are of use. Because I didn't see this error appear on the upgrade to Cypress 10 and beyond in SciGateway and DataGateway, I suspect Yarn plug-n-play and/or zero install are involved in this in some way and Cypress can't quite find what it's looking for (whether that be Typescript, the Cypress module itself or something else). I'm also fairly sure that the provided error message is closer to a red herring than an indication of what the actual problem might be. https://stackoverflow.com/questions/73221655/unknown-file-extension-ts-cypress-config-ts-on-ci |
Also the base branch for this is currently the auth branch (for testing purposes) but I never got that far so we'll have to make sure it's changed back to develop after that's merged |
@sam-glendenning looks like the last issue you referenced seems like the likely culprit as they admit that |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #158 +/- ##
========================================
Coverage 95.20% 95.20%
========================================
Files 76 76
Lines 3481 3481
Branches 964 964
========================================
Hits 3314 3314
Misses 165 165
Partials 2 2
☔ View full report in Codecov by Sentry. |
See issues linked in PR for details
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works both locally and on CI - just had to use a specific version that works nicely with Yarn PnP and not use a ts config file and instead use a CJS js config file
Description
Updates from current version v9.7.0.
Testing instructions
v9.7.0 should be gone and v12.0.2 in its place.
Agile board tracking
Closes DSEGOG-33