Add permalinks for announcements #1054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dauntlessnomad
approved these changes
Aug 10, 2019
|
Why not a separate view file like announcement-view.html or announcements/view.html ? |
|
@sreenadh Because it's easier to manage the announcement card view in one page itself. There's an additional proposal to add sharing buttons too. |
|
Share buttons can be put in separate view file and include both in both views. In future we might need more feature separately for view and announcements then announcements.html will get bloated with if else conditions. |
|
@sreenadh you're right. This was just a quick hack. In case there is more differences between the two, it should be separated. |
|
fix the conflicts please |
|
@tomahawk-pilot done |
This was referenced Aug 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Reference
This PR addresses the Issue : Fixes #1017
Summarize
Add permalinks for announcements
Sample URL : https://keralarescue.in/announcements/2 https://keralarescue.in/announcements/4