-
Notifications
You must be signed in to change notification settings - Fork 574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 1033. Proper title tag #1039
base: master
Are you sure you want to change the base?
Fix 1033. Proper title tag #1039
Conversation
Do we need to add Malayalam version ?, I found google -translator already translating titles to Malayalam |
Duplicate code <title>{% block title %}{% endblock %}Kerala Rescue</title>Change to <title>{% block title %}{% endblock %} - Kerala Rescue</title>And for individual pages, for eg To {% block title %}Announcements{% endblock %} |
@ajuajmal its better to pass title from controller so that we can use it directly in base.html for both breadcrumb's last tag and <title> tag and add parents only in individual views. Or define a breadcrumb class to define breadcrumbs in a centralized location and simply call the method in respective views along with title. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix merge conflicts
@ajuajmal please fix the merge conflicts. |
Issue Reference
This PR addresses the Issue : Fixes #1033
Changes
I had updated the base.html template with {% block title %}{% endblock %}
then extended it all other templates( html files)