Don't reference any actions in JobScoped concern, as it might not exist #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosa
changed the title
Thanks to @excid3 for spotting this. In Rails 7.1, because of the new default for `config.action_controller.raise_on_missing_callback_actions`, the except option used in `before_action` for `index` raises an error for those controllers that don't have an index action. Let's just remove that and let the only controller with an index action using this concern opt-out of it explicitly.
rosa
force-pushed
the
fix-unknown-action
branch
from
e7f914d to
cf7dbaf
Compare
|
No problemo! This solution is what I was thinking too, good to see we're on the same wavelength! 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @excid3 for spotting this in #46!
In Rails 7.1, because of the new default for
config.action_controller.raise_on_missing_callback_actions, the except option used inbefore_actionforindexraises an error for those controllers that don't have an index action. Let's just remove that and let the only controller with an index action using this concern opt-out of it explicitly.