Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retries fail because of missing controller action #46

Closed
excid3 opened this issue Jan 31, 2024 · 1 comment
Closed

Retries fail because of missing controller action #46

excid3 opened this issue Jan 31, 2024 · 1 comment

Comments

@excid3
Copy link
Contributor

excid3 commented Jan 31, 2024

The JobScoped concern sets a before_action on the index action that does not exist in the RetriesController. For retries, it needs to run on the create action instead.

This is caused by the new Rails 7.1 default config for raising errors on missing callback actions.

AbstractController::ActionNotFound (The index action could not be found for the :set_job
callback on MissionControl::Jobs::RetriesController, but it is listed in the controller's
:except option.

Raising for missing callback actions is a new default in Rails 7.1, if you'd
like to turn this off you can delete the option from the environment configurations
or set `config.action_controller.raise_on_missing_callback_actions` to `false`.
):

The before_action might need to get extracted to the controllers, but it would be nice if it didn't have to?

@rosa
Copy link
Member

rosa commented Jan 31, 2024

Ahhh, great catch @excid3! We've been running this in Rails 7.1 for a bit, but without having all of Rails 7.1 defaults yet. Because of that, we haven't run into this 😳 We'll fix it, will see how it'd look best 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants