Support for unified Integer class in Ruby 2.4+ #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruby 2.4 unifies Fixnum and Bignum into Integer: https://bugs.ruby-lang.org/issues/12005 Ruby ~2.3 `1234.class` is `Fixnum` and `123456789012345678901234567890.class` is `Bignum`. Ruby 2.4+ `1234.class` is `Integer` and `123456789012345678901234567890.class` is `Integer`. So what we should do is defining `visit_Integer` method to visitors.
|
LGTM |
amatsuda
added a commit
to amatsuda/bullet
that referenced
this pull request
Aug 11, 2024
Rails < 4.2 that require Arel < 6 doesn't seem to run on Ruby >= 2.5 due to this bug that was never backported to Arel < 6 rails/arel#439 And now that we support Ruby >= 2.7 only, no supported version of Ruby can run Rails < 4.2.
amatsuda
added a commit
to amatsuda/bullet
that referenced
this pull request
Aug 11, 2024
Rails < 4.2 that require Arel < 6 doesn't seem to run on Ruby >= 2.5 due to this bug that was never backported to Arel < 6 rails/arel#439 And now that we support Ruby >= 2.7 only, no supported version of Ruby can run Rails < 4.2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruby 2.4 unifies Fixnum and Bignum into Integer: https://bugs.ruby-lang.org/issues/12005
Ruby ~2.3
1234.classisFixnumand123456789012345678901234567890.classisBignum.Ruby 2.4+
1234.classisIntegerand123456789012345678901234567890.classisInteger.So what we should do is defining
visit_Integermethod to visitors.Backport of dc85a6e