Quit CIing against Rubies < 2.7 and Rails < 4.2 #713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Currently happening error on Rails 4.0 and 4.1 has been fixed with this patch in Arel 6, and this patch was not back ported to neither Arel 4 nor Arel 5. So I think there are two options for us:
WDYT? |
|
@amatsuda I was trying to upgrading ruby to 2.7.0 but not done yet, thanks for helping. |
amatsuda
changed the title
Rails < 4.2 that require Arel < 6 doesn't seem to run on Ruby >= 2.5 due to this bug that was never backported to Arel < 6 rails/arel#439 And now that we support Ruby >= 2.7 only, no supported version of Ruby can run Rails < 4.2.
because Rails 4 internally calls `BigDecimal.new` which has been removed since bigdecimal 2.0.
|
@flyerhzm OK, added another commit that drops Rails < 4.2 from the CI. |
|
@amatsuda thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows up bc8c3e6.
TBH I'm not sure if Ruby 2.7 can run all the tests here on Rails 4, but let's try anyway.