Prefer methods over instance variables #1166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -91,7 +91,7 @@ def self.serializer_for(resource, options = {}) | |||
| elsif resource.respond_to?(:to_ary) | |||
| config.array_serializer | |||
| else | |||
| options.fetch(:serializer, get_serializer_for(resource.class)) | |||
| options.fetch(:serializer) { get_serializer_for(resource.class) } | |||
There was a problem hiding this comment.
not required for PR, just lazy evals the method when the fetch fails
| @scope = options[:scope] | ||
|
|
||
| scope_name = options[:scope_name] | ||
| self.object = object |
There was a problem hiding this comment.
why prefer self over just the attribute?
it does differentiate from potential local variables. but I'm curious if there is anything else
There was a problem hiding this comment.
why prefer self over just the attribute?
Not sure what you mean by that.
see my answer #1166 (comment)
|
I'm mostly just confused on when |
|
@NullVoxPopuli here's the rules for
|
bf4
force-pushed
the
clarify_options_variable
branch
from
e918fdc to
28ac9cb
Compare
| @_attributes.concat attrs | ||
| @_attributes.uniq! | ||
| self._attributes.concat(attrs) | ||
| self._attributes.uniq! |
There was a problem hiding this comment.
So, @beauby you're right that these don't need self
bf4
force-pushed
the
clarify_options_variable
branch
from
28ac9cb to
9d65f0a
Compare
|
👍 |
NullVoxPopuli
added a commit
that referenced
this pull request
Sep 17, 2015
Prefer methods over instance variables
This was referenced Sep 17, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a refactor.
Also, extracted latent Adapter::CachedSerializer class. See comments
Basically, wherever
optionswas a method argument in a class, I renamed the@optionsivar toinstance_optionsand added an attr_reader. I think it's a good practice to prefer getters/setters over ivars as it gives better failures and encapsulation.Done in response to #1165 which describes a failure where the
optionsattribute is confused withoptions.While changing the options ivars, I just changed all of them.