Prefer setters over ivars #1116
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @meta = options[:meta] | ||
| @meta_key = options[:meta_key] | ||
| @scope = options[:scope] | ||
| def initialize(object, opts = {}) |
There was a problem hiding this comment.
Any reason for the options → opts change?
There was a problem hiding this comment.
Good eye. Because there is an options method set by @options method and options arguments passed to method that are not the same thing, so I thought to distinguish. Methods blow up more more nicely than ivars, too :)
There was a problem hiding this comment.
though in the scope of this initializer, they may still be called options, now that I think about it
|
Closed in favor of #1166 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.