dependencies: Update dependency ethers to v5 #2289

renovate · 2020-10-23T13:10:11Z

Fixes #1707
Upgrades ethers to v5 and switch pnpm for yarn workspaces, since pnpm had issues detecting and installing sub-dependencies of ethers v5.

This PR contains the following updates:

Package	Type	Update	Change
ethers	peerDependencies	major	`^4.0.48` -> `^5.0.19`
ethers	dependencies	major	`^4.0.48` -> `^5.0.19`

Release Notes

ethers-io/ethers.js

`v5.0.19`

Compare Source

Allow 0x as a numeric value for 0 in Provider formatter. (#1104; fe17a29)
- Use POST for long requests in EtherscanProvider. (#1093; 28f60d5)
- Added verifyTypedData for EIP-712 typed data. (#687; 550ecf2, a21202c)

`v5.0.18`

Compare Source

Fix signTypedData call for JsonRpcSigner. (#687; 15a90af)
- Added EIP-712 test cases. (#687; 1589353)
- Initial Signer support for EIP-712 signed typed data. (#687; be4e216)
- Split hash library files up. (3e676f2)
- Added EIP-712 multi-dimensional array support. (#687; 5a4dd5a)
- Consolidated TypedDataEncoder methods. (#687; 345a830)
- Initial EIP-712 utilities. (#687; cfa6dec)
- Added initial PocketProvider. (#1052; a62d20d)

`v5.0.17`

Compare Source

Better error message for parseUnits of non-strings. (#981; 5abc2f3)
- Add gzip support to AlchemyProivder and InfuraProvider fetching. (#1085; 38a068b)
- Add gzip support to getUrl in node. (#1085; 65772a8)
- Added CommunityResourcable to mark Providers as highly throttled. (a022093)
- Added debug event info to WebSocketProvider. (#1018; 8e682cc)

`v5.0.16`

Compare Source

ABI encoding performance additions. (#1012; f3e5b0d)
- Export hexConcat in utils. (#1079; 3d051e4)
- Cache chain ID for WebSocketProvider. (#1054; 40264ff)

`v5.0.15`

Compare Source

Add more accurate intrinsic gas cost to ABI calls with specified gas property. (#1058; f0a5869)
- Better errors for unconfigured ENS names. (#1066; 5cd1668)
- Updated CLI solc to versin 0.7.1. (4306b35)

`v5.0.14`

Compare Source

More robust blockchain error detection (#1047; 49f7157)
- Forward blockchain errors from Signer during gas estimation. (#1047; 9ee685d)
- Improve fetch errors with looser mime-type detection. (#1047; 263bfe5)

`v5.0.13`

Compare Source

Force content-length in web fetching. (be92339)
- Better error forwarding from FallbackProvider. (#1021; bc3eeec)
- Add clamping functions to FixedNumber. (#1037; 042b74e)

`v5.0.12`

Compare Source

Allow events to use compact bytes ABI coded data for Solidity 0.4 external events. (#891, #992; 4e394fc)

`v5.0.11`

Compare Source

Synced unorm in shims to most recent version. (bdccf7b)
- Fixed LedgerSigner sendTransaction. (#936; cadb28d)
- Added BrainWallet to experimental exports. (72385c2)
- More readable server errors. (201e5ce)

`v5.0.10`

Compare Source

Added retry logic to provider tests. (0558bba, 35b64b9, 681f2a5)
- Fixed link in docs. (#1028; 2359a98)
- Added memory-like support and new opcodes to asm. (6fd3bb6)
- Added basic ENS resolver functions for contenthash, text and multi-coin addresses. (#1003; 83db8a6)
- Added support for changing Reporter logging function. (d01d0c8)
- Initial React Native test harness. (#993; 57eb5b7, d3b473e)
- Updating shims for constrained environments. (#944, #993; 8abdbbb, 240aac5)

`v5.0.9`

Compare Source

Updated docs for all packages on npm pages. (#1013; cb8f4a3)
- Added JSON support to BigNumber. (#1010; 8facc1a)
- Updated packages for security audit. (5b5904e)
- Fix emitted error for ABI code array count mismatch. (#1004; b0c082d)

`v5.0.8`

Compare Source

Abstract fetchJson for data. (e2d6f28, 2c49a52, e1bbb06)

`v5.0.7`

Compare Source

Fix Logger setLogLevel with enum case mismatch. (#947; 5443363, af10705)
- Removed UUID dependency from json-wallets. (#966; e3f7426)
- Removed unnecessary dependency from BigNumber. (#951; 78b350b)

`v5.0.6`

Compare Source

Removed unnecessary dependency from BigNumber. (#951; 78b350b)
- Longer Etherscan throttle slot interval. (9f20258)
- Fixed ENS overrides for the default provider. (#959; 63dd3d4)
- Added Retry-After support and adjustable slot interval to fetchJson. (7d43545)
- Added initial throttling support. (#139, #904, #926; 88c7eae)
- Use status code 1000 on WebSocket hangup for compatibility. (588f64c)
- Updated WebSocketProvider to use web-style event listener API. (57fd6f0)
- Normalize formatUnits to simplified decimals. (79b1da1)
- Prevent zero-padding on Solidity type lengths. (e128bfc)
- Set sensible defaults for INFURA and AlchemyAPI getWebSocketProvider methods. (e3d3e60)
- Added logger assert methods. (619a888)
- Added initial code coverage testing. (0c1d55b)
- Added destroy to WebSocketProvider. (d0a79c6)
- Updated packages (security updates). (c660176)

`v5.0.5`

Compare Source

Fixed splitSignature when recoveryParam is encoded directly. (#893, #933; bf65ddb)
- Fixed BigNumber string validation. (#935; 7e56f3d)

`v5.0.4`

Compare Source

Prevent negative exponents in BigNumber. (#925; 84e253f)
- Fixed StaticJsonRpcProvider when auto-detecting network. (#901; 0fd9aa5)
- Added WebSocket static method to Alchemy provider and updated Alchemy URLs. (4838874)

`v5.0.3`

Compare Source

Fixed typo in error string. (7fe702d)
- Updated elliptic package to address possible malleability issue; which should not affect Ethereum. (9e14345)
- Fixed FixedNumber unguarded constructor and added isZero. (#898; 08c74e9)
- Added StaticJsonRpcProvider for reducing calls to chainId in certain cases. (#901; c53864d)
- Allow getDefaultProvider to accept a URL as a network. (8c1ff4c)
- Make network an optional parameter to WebSocketProvider. (987b535)
- Removed deprecated errors package. (f9e9347)
- Updated badges in docs. (d00362e)
- Create security policy. Create security policy. (88e6849)

`v5.0.2`

Compare Source

Allow provider.ready to stall until the network is available. (#882; bbb4f40)
- Reduce dependencies to squash security issues. (738d349)
- Updated admin scripts for publishing prod releases. (e0e0dbe)

`v5.0.1`

Compare Source

Allow 0x as a numeric value for 0 in Provider formatter. (#1104; fe17a29)
- Use POST for long requests in EtherscanProvider. (#1093; 28f60d5)
- Added verifyTypedData for EIP-712 typed data. (#687; 550ecf2, a21202c)

`v5.0.0`

Compare Source

Preserve config canary string. (7157816)
- Updated docs. (9e4c7e6)

Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.

If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

CLAassistant · 2020-10-23T13:10:17Z

All committers have signed the CLA.

github-actions · 2020-10-27T23:29:38Z

You modified raiden-dapp/src,
Please remember to add a change log entry at raiden-dapp/CHANGELOG.md if necessary.

andrevmatos · 2020-10-27T23:58:17Z

Ok, I managed to get the SDK to build with ethers v5.
So, the SDK part should be done until we get the rest of the imports fixed and are able to test with automated tests and build the dApp to test it by hand, then we go back to fix SDK if needed.
This part can be split out, and worked in parallel. If we do it right, there shouldn't be rebase/merge conflicts, as long as you keep an eye to pull committed changes before committing their part.

sdk src imports (@andrevmatos)
sdk tests imports (@andrevmatos)
dapp imports (@weilbith, can you do it, please?)
cli imports (@palango, can you do it, please?)
sdk tests fixes (@andrevmatos, after builds pass)

andrevmatos · 2020-10-28T00:15:05Z

Some implementation suggestions:
On ethers v5, the library is split among several namespaced packages (under @ethersproject), and then the exported/relevant members are exported as the ethers package.

On SDK, in order to minimize code changes, I opted to import the named exports from the @ethersproject packages. @agatsoh , please, try to keep it like that also on the SDK tests imports: e.g. BigNumber is now imported from @ethersproject/bignumber, Network is imported from @ethersproject/networks, etc. Please, refer to the current commits for examples from where you should import the previous names. Also, you can refer to the ethers.ts and utils.ts to identify from which package a var/function/type is imported. I already added most of the required packages, but you can also add a new from the namespace if not already included. Please, if you import some name only for its type, try to use import type feature.

On dApp and CLI, I think it's not worth the weight of adding the individual namespaced packages, so we should use the types and exports from the ethers package. Downside is that some things aren't name-exported, so you may need to use it from the modules. e.g. BigNumber can be imported from ethers, but most utils are inside some re-exported objects, so one may need to use something like

import { BigNumber, ethers } from 'ethers';
const formated = ethers.utils.formatEther(BigNumber.from(10));

i.e. accessing from the namespaced mapping object, in order to use utilities and even some types from the exported subpackages, specially from ethers.utils, ethers.constants and ethers.providers.

As already shown above, bigNumberify is gone, and one must use BigNumber.from to create BigNumber instances from now on. Please, refer to the migrations guide and commits already in this PR for examples.

Please, let me know if there's any question. Thank you very much.

weilbith · 2020-10-28T09:51:55Z

Thank you very much @andrevmatos 🙏

Hmm, I think the package for the dApp is already huge. Also I do not like to use the namespace objects to much. 🤔
Let's see how much we actually need from the whole namespace and then I would like to do the decision which approach fits better.

Btw: Does the @ not clash with our webpack configuration? 🤔

weilbith · 2020-10-28T10:26:46Z

Note for the careful reader: @palango his question was answered in a channel external of GitHub.

andrevmatos · 2020-10-28T10:50:17Z

Hmm, I think the package for the dApp is already huge. Also I do not like to use the namespace objects to much.
Let's see how much we actually need from the whole namespace and then I would like to do the decision which approach fits better.

We need to test. These packages should be imported from their (new) ESM build automatically by tools like webpack, so maybe it won't grow the package in any way more than using the namespaced packages. Notice also importing from the exports in ethers is the suggested way in their documentation, and I had to dig about to be able to import from the projects subpackages to get the named exports out of it for the SDK.

Btw: Does the @ not clash with our webpack configuration?

It shouldn't, because it's not @/ , and instead @etherspackage/, which differentiates.

weilbith · 2020-10-28T10:50:22Z

Btw: Does the @ not clash with our webpack configuration? 🤔

Okay no, at least for the dApp this is configured as @/.

andrevmatos · 2020-10-29T01:05:35Z

@agatsoh So I think I managed to fix tests fixtures and mocks. Most channels.spec.ts tests, and all utils.spec.ts are already passing, so you can start converting the rest of the tests. Please, let me know if you have any question, but the previous commits should give you good leads on how to proceed.

If ts-jest keeps bothering you because some unrelated test is failing to compile (since it always tries to transpile everything), you may temporarily and only on your workdir enable isolated modules option, which will allow you to force-run each test suite despite transpile errors and check if they pass, and then you should be able to disable it again after all tests are fixed.

codecov · 2020-10-30T01:08:52Z

Codecov Report

Merging #2289 into master will decrease coverage by 0.14%.
The diff coverage is 98.28%.

@@            Coverage Diff             @@
##           master    #2289      +/-   ##
==========================================
- Coverage   94.94%   94.80%   -0.15%     
==========================================
  Files         156      156              
  Lines        6293     6294       +1     
  Branches     1166     1078      -88     
==========================================
- Hits         5975     5967       -8     
- Misses        253      262       +9     
  Partials       65       65

Flag	Coverage Δ
dapp	`91.83% <97.50%> (-0.02%)`	⬇️
sdk	`95.99% <98.51%> (-0.20%)`	⬇️
sdk_e2e	`?`
sdk_integration	`68.58% <87.40%> (+0.03%)`	⬆️
sdk_unit	`85.53% <87.40%> (-0.06%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
raiden-dapp/src/components/AmountDisplay.vue	`100.00% <ø> (ø)`
...en-dapp/src/components/channels/ChannelDialogs.vue	`100.00% <ø> (ø)`
.../src/components/dialogs/TransferProgressDialog.vue	`94.44% <ø> (ø)`
raiden-dapp/src/filters.ts	`100.00% <ø> (ø)`
raiden-dapp/src/store/index.ts	`98.05% <ø> (ø)`
raiden-ts/src/channels/state.ts	`100.00% <ø> (ø)`
raiden-ts/src/services/types.ts	`100.00% <ø> (ø)`
raiden-ts/src/transfers/state.ts	`100.00% <ø> (ø)`
raiden-ts/src/types.ts	`100.00% <ø> (ø)`
raiden-dapp/src/views/OpenChannelRoute.vue	`92.18% <50.00%> (ø)`
... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 073b06f...ce704ab. Read the comment docs.

andrevmatos · 2020-10-30T01:28:24Z

SDK tests are green. I'll investigate the dApp build errors tomorrow. They're caused by tsc/webpack not seeing the sub-dependencies of the ethers package, probably because of how pnpm links them.
Solution may be to switch to yarn workspaces.
@weilbith if you wanna give a look at ^--

andrevmatos · 2020-10-31T22:02:48Z

I have tested it: transfers, channel open, close, deposit, UDC deposit, UDC withdraw, ETH subkey deposit.. everything seems to be working as expected.
@taleldayekh I've got some weird errors when accessing the notification area (it looks like there should be some notifications there which didn't show up because of this error). Can you confirm it's not related to this upgrade?
The error:

vue.runtime.esm.js:1888 Error: Cannot find module './undefined.svg'
    at webpackContextResolve (eval at ./src/assets sync recursive ^\.\/.*\.svg$ (13.js:148), <anonymous>:38:11)
    at webpackContext (eval at ./src/assets sync recursive ^\.\/.*\.svg$ (13.js:148), <anonymous>:33:11)
    at Proxy.render (eval at ../node_modules/cache-loader/dist/cjs.js?{"cacheDirectory":"node_modules/.cache/vue-loader","cacheIdentifier":"2a8bdb58-vue-loader-template"}!../node_modules/vue-loader/lib/loaders/templateLoader.js?!../node_modules/cache-loader/dist/cjs.js?!../node_modules/vue-loader/lib/index.js?!./src/components/notification-panel/NotificationCard.vue?vue&type=template&id=5cb96eb0&scoped=true& (13.js:47), <anonymous>:28:91)
    at VueComponent.Vue._render (vue.runtime.esm.js:3548)
    at VueComponent.updateComponent (vue.runtime.esm.js:4066)
    at Watcher.get (vue.runtime.esm.js:4479)
    at new Watcher (vue.runtime.esm.js:4468)
    at mountComponent (vue.runtime.esm.js:4073)
    at VueComponent.Vue.$mount (vue.runtime.esm.js:8415)
    at init (vue.runtime.esm.js:3118)

weilbith · 2020-11-01T10:41:29Z

@taleldayekh I've got some weird errors when accessing the notification area (it looks like there should be some notifications there which didn't show up because of this error). Can you confirm it's not related to this upgrade?
The error:

Allow me to answer for him: yes, atm this is an issue for some notifications. @taleldayekh was there an issue to add all missing icons?

weilbith

@andrevmatos thank you so much for all the work you have invested here! 🙏
I was prepared this morning to start to fully adopt the project from pnpm to yarn but you already did it. All the changes look good to me. 👍

renovate bot added the dependencies Pull requests that update a dependency file label Oct 23, 2020

andrevmatos force-pushed the renovate/ethers-5.x branch from fb35ac2 to 2764024 Compare October 27, 2020 23:29

andrevmatos force-pushed the renovate/ethers-5.x branch from 2764024 to dc1aa7b Compare October 27, 2020 23:32

palango force-pushed the renovate/ethers-5.x branch from 398de3e to bb294e8 Compare October 28, 2020 11:40

christianbrb mentioned this pull request Oct 28, 2020

Upgrade to ethers v5 #1707

Closed

10 tasks

andrevmatos force-pushed the renovate/ethers-5.x branch 2 times, most recently from 287e0f4 to 42e7d76 Compare October 30, 2020 00:56

dependencies: Update dependency ethers to v5

19119ed

andrevmatos force-pushed the renovate/ethers-5.x branch 2 times, most recently from 2076fe1 to 140ca4d Compare October 31, 2020 03:07

andrevmatos requested a review from weilbith October 31, 2020 03:46

andrevmatos self-assigned this Oct 31, 2020

andrevmatos added the infrastructure 🚧 Tests, CI, and general project infrastructure label Oct 31, 2020

andrevmatos approved these changes Oct 31, 2020

View reviewed changes

andrevmatos and others added 5 commits October 31, 2020 11:18

sdk: upgrade typechain to ethers-v5 and add its projects dependencies

1fd1a16

sdk: adapt imports to ethers v5

fd2ad68

cli: fix imports in raiden-cli for ethers v5

8d5e508

sdk: remove patchSignSend, not needed anymore with ethers v5

ae80507

sdk: tests: adapt mocks & fixtures

fa23d1a

andrevmatos and others added 7 commits October 31, 2020 11:18

sdk: adapt channels & utils tests

55e0bd7

sdk: remove custom getNetwork and simplify initMonitorProviderEpic

830d8cf

sdk: adapt monitor, path, transport & raiden unit tests

7f0df39

sdk: fix rest of unit tests

7aed4f9

sdk: adapt default blockNumber getter returning -1 instead of undefined

73a305f

sdk: adapt integration tests

8a1795c

dApp: convert to ethers v5 global exports module

443440f

andrevmatos force-pushed the renovate/ethers-5.x branch from a4cc243 to 2d9ca28 Compare October 31, 2020 14:25

andrevmatos mentioned this pull request Oct 31, 2020

Investigate and reduce bundle size #744

Closed

1 task

andrevmatos added 4 commits November 1, 2020 14:06

infra: replace pnpm with yarn workspaces

5903d82

dapp: fix linting errors

ca8b0f2

sdk: add changelog entries

7892e82

deps: adjust renovate schedule and lockFileMaintenance config for yarn

ce704ab

andrevmatos force-pushed the renovate/ethers-5.x branch from dcb9e21 to ce704ab Compare November 1, 2020 17:06

weilbith approved these changes Nov 2, 2020

View reviewed changes

weilbith mentioned this pull request Nov 2, 2020

Feature/ci improvements and fixes #2292

Merged

andrevmatos merged commit dde6594 into master Nov 2, 2020

andrevmatos deleted the renovate/ethers-5.x branch November 2, 2020 10:44

palango mentioned this pull request Nov 5, 2020

sdk-integration-tests: runtime regression #2324

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

dependencies: Update dependency ethers to v5 #2289

dependencies: Update dependency ethers to v5 #2289

renovate bot commented Oct 23, 2020 •

edited by andrevmatos

Loading

CLAassistant commented Oct 23, 2020 •

edited

Loading

github-actions bot commented Oct 27, 2020 •

edited

Loading

andrevmatos commented Oct 27, 2020 •

edited

Loading

andrevmatos commented Oct 28, 2020

weilbith commented Oct 28, 2020 •

edited

Loading

weilbith commented Oct 28, 2020

andrevmatos commented Oct 28, 2020 •

edited

Loading

weilbith commented Oct 28, 2020 •

edited

Loading

andrevmatos commented Oct 29, 2020

codecov bot commented Oct 30, 2020 •

edited

Loading

andrevmatos commented Oct 30, 2020 •

edited

Loading

andrevmatos commented Oct 31, 2020

weilbith commented Nov 1, 2020

weilbith left a comment

dependencies: Update dependency ethers to v5 #2289

dependencies: Update dependency ethers to v5 #2289

Conversation

renovate bot commented Oct 23, 2020 • edited by andrevmatos Loading

Release Notes

Renovate configuration

CLAassistant commented Oct 23, 2020 • edited Loading

github-actions bot commented Oct 27, 2020 • edited Loading

andrevmatos commented Oct 27, 2020 • edited Loading

andrevmatos commented Oct 28, 2020

weilbith commented Oct 28, 2020 • edited Loading

weilbith commented Oct 28, 2020

andrevmatos commented Oct 28, 2020 • edited Loading

weilbith commented Oct 28, 2020 • edited Loading

andrevmatos commented Oct 29, 2020

codecov bot commented Oct 30, 2020 • edited Loading

Codecov Report

andrevmatos commented Oct 30, 2020 • edited Loading

andrevmatos commented Oct 31, 2020

weilbith commented Nov 1, 2020

weilbith left a comment

Choose a reason for hiding this comment

renovate bot commented Oct 23, 2020 •

edited by andrevmatos

Loading

CLAassistant commented Oct 23, 2020 •

edited

Loading

github-actions bot commented Oct 27, 2020 •

edited

Loading

andrevmatos commented Oct 27, 2020 •

edited

Loading

weilbith commented Oct 28, 2020 •

edited

Loading

andrevmatos commented Oct 28, 2020 •

edited

Loading

weilbith commented Oct 28, 2020 •

edited

Loading

codecov bot commented Oct 30, 2020 •

edited

Loading

andrevmatos commented Oct 30, 2020 •

edited

Loading