Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to ethers v5 #1707

Closed
10 tasks done
andrevmatos opened this issue Jun 15, 2020 · 3 comments · Fixed by #2289
Closed
10 tasks done

Upgrade to ethers v5 #1707

andrevmatos opened this issue Jun 15, 2020 · 3 comments · Fixed by #2289
Assignees
Labels
5 cli 🔤 Command-line SDK-based Node.js Client issues dApp 📱 dependencies Pull requests that update a dependency file Ready 🎬 Issues which are ready to be pulled into the iteration refactor sdk 🖥

Comments

@andrevmatos
Copy link
Contributor

andrevmatos commented Jun 15, 2020

Description

Ethers v5 is a big refactoring of the ethers web3 library, the core of our blockchain interaction. This major release changes a lot of utility functions and assumptions. Considering we rely quite deeply on some v4 implementation details, this should be a larger task, but the improvements, new features, stability and bugfixes it brings is worth it, so we should do this sooner than later, to avoid writing more code that will be needed to be refactored.

Acceptance criteria

  • We use ethers v5 on the whole codebase
  • It works the same as before (no regressions)
  • Events are reviewed in detail

see #2289 (comment) for details

Tasks

@andrevmatos andrevmatos added sdk 🖥 dApp 📱 refactor dependencies Pull requests that update a dependency file cli 🔤 Command-line SDK-based Node.js Client issues labels Jun 15, 2020
@andrevmatos andrevmatos added this to the Product Backlog milestone Jun 15, 2020
@christianbrb christianbrb removed this from the Product Backlog milestone Jun 24, 2020
@andrevmatos
Copy link
Contributor Author

@typechain/ethers-v5@1.0.0 is merged and released. We should do this soon, this is quite an important library for us to stay behind too long.

@christianbrb christianbrb added this to the Product Backlog milestone Aug 4, 2020
@christianbrb
Copy link
Contributor

The migration guide: https://docs.ethers.io/v5/migration/ethers-v4/

@christianbrb christianbrb added the Ready 🎬 Issues which are ready to be pulled into the iteration label Aug 28, 2020
@christianbrb

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 cli 🔤 Command-line SDK-based Node.js Client issues dApp 📱 dependencies Pull requests that update a dependency file Ready 🎬 Issues which are ready to be pulled into the iteration refactor sdk 🖥
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants