Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Begin End ranges #585

Merged
merged 13 commits into from
Mar 9, 2024
Merged

add Begin End ranges #585

merged 13 commits into from
Mar 9, 2024

Conversation

rafaqz
Copy link
Owner

@rafaqz rafaqz commented Dec 26, 2023

its been really annoying me lately that we can't use begin and end in dimensional getindex.

So I'm considering repurposing our exising Start/End types to use as placeholders in ranges to work like begin and end (probably making an alias Begin = Start.

Closes #195

Copy link

codecov bot commented Mar 9, 2024

Codecov Report

Attention: Patch coverage is 73.39744% with 83 lines in your changes are missing coverage. Please review.

Project coverage is 83.01%. Comparing base (9846bfe) to head (5b95090).

Files Patch % Lines
src/Lookups/beginend.jl 44.44% 30 Missing ⚠️
src/array/indexing.jl 55.73% 27 Missing ⚠️
src/Dimensions/format.jl 84.09% 7 Missing ⚠️
src/Lookups/set.jl 76.19% 5 Missing ⚠️
src/stack/indexing.jl 66.66% 5 Missing ⚠️
src/Lookups/indexing.jl 40.00% 3 Missing ⚠️
src/Lookups/selector.jl 88.88% 3 Missing ⚠️
src/Dimensions/dimension.jl 66.66% 1 Missing ⚠️
src/Lookups/lookup_arrays.jl 96.55% 1 Missing ⚠️
src/Lookups/utils.jl 94.44% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #585      +/-   ##
==========================================
- Coverage   83.83%   83.01%   -0.83%     
==========================================
  Files          45       46       +1     
  Lines        4102     4191      +89     
==========================================
+ Hits         3439     3479      +40     
- Misses        663      712      +49     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rafaqz rafaqz merged commit 338fa26 into main Mar 9, 2024
4 of 7 checks passed
@rafaqz rafaqz deleted the begin_end_types branch March 9, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Indexing with end fails in simple cases
1 participant