Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove scientific extension #1104

Merged
merged 1 commit into from
Apr 28, 2021
Merged

Conversation

cholmes
Copy link
Contributor

@cholmes cholmes commented Apr 26, 2021

Related Issue(s): #1045 #1093

Proposed Changes:

  1. Remove scientific so we can merge this, as discussed in https://github.com/radiantearth/stac-spec/pull/1093/files#r620248117 so we don't have to wait for Collection Schema stac-extensions/scientific#2 to merge.

PR Checklist:

  • This PR is made against the dev branch (all proposed changes except releases should be against dev, not master).
  • This PR has no breaking changes.
  • I have added my changes to the CHANGELOG

@cholmes cholmes mentioned this pull request Apr 26, 2021
4 tasks
@@ -83,11 +82,6 @@
"minimum": 6.78,
"maximum": 89.9
},
"sci:citation": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bummer, that was an interesting use case where you actually define a pattern for values. We should try to come up with such a use case for another extension field.

@cholmes cholmes merged commit 91a435e into json-schema-summaries Apr 28, 2021
@m-mohr m-mohr deleted the no-scientific-1093 branch May 13, 2021 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants