Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate scientific extension, update for #1045 (merge after scientific extension 1.0.0 release) #1103

Closed
wants to merge 2 commits into from

Conversation

cholmes
Copy link
Contributor

@cholmes cholmes commented Apr 26, 2021

Related Issue(s): #1093 stac-extensions/scientific#2

Proposed Changes:

  1. Bring in the updated scientific example, so we can release rc.3 without waiting on Collection Schema stac-extensions/scientific#2, as discussed in https://github.com/radiantearth/stac-spec/pull/1093/files#r620248117

PR Checklist:

  • This PR is made against the dev branch (all proposed changes except releases should be against dev, not master).
  • This PR has no breaking changes.
  • a CHANGELOG entry is not required.

@cholmes cholmes mentioned this pull request Apr 26, 2021
4 tasks
@m-mohr
Copy link
Collaborator

m-mohr commented Apr 27, 2021

I don't understand this PR? Do we remove the example for RC3 through #1104 and then add it back again after RC3? In this case the Schema URL needs to update from 1.0.0 to 1.0.1.

@cholmes
Copy link
Contributor Author

cholmes commented Apr 27, 2021

I thought that's what you were intending, but I wasn't sure, so happy to take another route.

My take was we should try to release rc.3 asap, and if it's an example of an extension that is blocking us then we should just take that out. But I think it's a good example, so whenever it's in good shape then we should merge it back in.

But if it can happen today/tomorrow I'm for just merging in the scientific fix and cutting 1.0.1 from there as the route to unblock this.

@m-mohr
Copy link
Collaborator

m-mohr commented Apr 27, 2021

So this PR is not meant to be merged for RC3, understood. Then we need to update the schema URI, of course.

Co-authored-by: Matthias Mohr <m.mohr@uni-muenster.de>
@cholmes cholmes changed the title Validate scientific extension, update for #1045 Validate scientific extension, update for #1045 (merge after scientific extension 1.0.0 release) Apr 28, 2021
@m-mohr m-mohr self-assigned this Sep 10, 2021
@m-mohr
Copy link
Collaborator

m-mohr commented Oct 5, 2021

Looking at it again, I think we could simply not merge it and have these examples in the corresponding extension repos. It's nothing major anyway.

@m-mohr m-mohr closed this Oct 5, 2021
@m-mohr m-mohr deleted the scientific-validation branch October 5, 2021 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants