Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert functions result form long to ulong #258

Merged
merged 1 commit into from
Mar 31, 2023

Conversation

e-zoob
Copy link
Contributor

@e-zoob e-zoob commented Mar 30, 2023

Fixes: #257

@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (c1b9961) 92.90% compared to head (117f4da) 92.90%.

❗ Current head 117f4da differs from pull request most recent head ba5e38c. Consider uploading reports for the commit ba5e38c to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #258   +/-   ##
=======================================
  Coverage   92.90%   92.90%           
=======================================
  Files         102      102           
  Lines        8871     8871           
  Branches      704      704           
=======================================
  Hits         8242     8242           
  Misses        485      485           
  Partials      144      144           
Impacted Files Coverage Δ
RabbitMQ.Stream.Client/StreamStats.cs 100.00% <100.00%> (ø)
Tests/SystemTests.cs 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Gsantomaggio Gsantomaggio merged commit dceba9d into rabbitmq:main Mar 31, 2023
@Gsantomaggio
Copy link
Member

thank you @e-zoboli

@e-zoob
Copy link
Contributor Author

e-zoob commented Mar 31, 2023

You'welcome, I'm happy to help

@Gsantomaggio Gsantomaggio added this to the 1.3.0 milestone Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Offset should consistently be either a long or a ulong
2 participants