Convert functions result form long to ulong (#258)

Fixes: #257
rabbitmq · Mar 31, 2023 · dceba9d · dceba9d
1 parent c1b9961
commit dceba9d
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 10 deletions.
diff --git a/RabbitMQ.Stream.Client/PublicAPI.Unshipped.txt b/RabbitMQ.Stream.Client/PublicAPI.Unshipped.txt
@@ -13,9 +13,9 @@ RabbitMQ.Stream.Client.Reliable.DeduplicatingProducerConfig
 RabbitMQ.Stream.Client.Reliable.DeduplicatingProducerConfig.DeduplicatingProducerConfig(RabbitMQ.Stream.Client.StreamSystem streamSystem, string stream, string reference) -> void
 RabbitMQ.Stream.Client.Reliable.ProducerConfig.Reference.set -> void
 RabbitMQ.Stream.Client.StreamStats
-RabbitMQ.Stream.Client.StreamStats.CommittedChunkId() -> long
-RabbitMQ.Stream.Client.StreamStats.FirstOffset() -> long
-RabbitMQ.Stream.Client.StreamStats.LastOffset() -> long
+RabbitMQ.Stream.Client.StreamStats.CommittedChunkId() -> ulong
+RabbitMQ.Stream.Client.StreamStats.FirstOffset() -> ulong
+RabbitMQ.Stream.Client.StreamStats.LastOffset() -> ulong
 RabbitMQ.Stream.Client.StreamStatsResponse
 RabbitMQ.Stream.Client.StreamStatsResponse.CorrelationId.get -> uint
 RabbitMQ.Stream.Client.StreamStatsResponse.ResponseCode.get -> RabbitMQ.Stream.Client.ResponseCode

diff --git a/RabbitMQ.Stream.Client/StreamStats.cs b/RabbitMQ.Stream.Client/StreamStats.cs
@@ -22,11 +22,11 @@ private void MaybeOffsetNotFound(long value, string offsetType)
     /// return first offset in the stream
     /// throws NoOffsetException if there is no first offset yet
     /// </summary>
-    public long FirstOffset()
+    public ulong FirstOffset()
     {
         var r = _statistics.TryGetValue("first_chunk_id", out var value) ? value : -1;
         MaybeOffsetNotFound(value, "FirstOffset");
-        return r;
+        return (ulong)r;
     }
 
     /// <summary>
@@ -35,11 +35,11 @@ public long FirstOffset()
     /// return last offset in the stream
     /// throws NoOffsetException if there is no first offset yet
     /// </summary>
-    public long LastOffset()
+    public ulong LastOffset()
     {
         var r = _statistics.TryGetValue("last_chunk_id", out var value) ? value : -1;
         MaybeOffsetNotFound(value, "LastOffset");
-        return r;
+        return (ulong)r;
     }
 
     /// <summary>
@@ -56,11 +56,11 @@ public long LastOffset()
     /// throws NoOffsetException if there is no committed chunk yet
     ///
     /// </summary>
-    public long CommittedChunkId()
+    public ulong CommittedChunkId()
     {
         var r = _statistics.TryGetValue("committed_chunk_id", out var value) ? value : -1;
         MaybeOffsetNotFound(value, "CommittedChunkId");
-        return r;
+        return (ulong)r;
     }
 
     private readonly IDictionary<string, long> _statistics;

diff --git a/Tests/SystemTests.cs b/Tests/SystemTests.cs
@@ -135,7 +135,7 @@ public async void StreamStatus()
             await SystemUtils.PublishMessages(system, stream, 500, _testOutputHelper);
             SystemUtils.Wait();
             var statAfter = await system.StreamStats(stream);
-            Assert.Equal(0, statAfter.FirstOffset());
+            Assert.Equal((ulong)0, statAfter.FirstOffset());
             Assert.True(statAfter.LastOffset() > 0);
             Assert.True(statAfter.CommittedChunkId() > 0);
             await SystemUtils.CleanUpStreamSystem(system, stream);