Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of isFALSE to allow use of R < 3.5 #230

Merged
merged 3 commits into from
Mar 17, 2020

Conversation

langmm
Copy link
Contributor

@langmm langmm commented Mar 16, 2020

Closes #229

@codecov
Copy link

codecov bot commented Mar 16, 2020

Codecov Report

Merging #230 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #230      +/-   ##
==========================================
+ Coverage   94.09%   94.09%   +<.01%     
==========================================
  Files          18       18              
  Lines         897      898       +1     
==========================================
+ Hits          844      845       +1     
  Misses         53       53
Impacted Files Coverage Δ
R/symbolic_units.R 98.8% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1e01bc...c5adbd8. Read the comment docs.

@Enchufa2
Copy link
Member

I think it's more safe and clear if we just port the function and keep the syntax. Also, I've bumped the version and updated the NEWS. Many thanks!

@Enchufa2 Enchufa2 merged commit ad554d5 into r-quantities:master Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use of isFALSE requires R>=3.5
2 participants