Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use of isFALSE requires R>=3.5 #229

Closed
langmm opened this issue Mar 16, 2020 · 4 comments · Fixed by #230
Closed

Use of isFALSE requires R>=3.5 #229

langmm opened this issue Mar 16, 2020 · 4 comments · Fixed by #230

Comments

@langmm
Copy link
Contributor

langmm commented Mar 16, 2020

In the recent release 0.6-6, the isFALSE function is used in R/symbolic_units.R which causes calls to units to fail on R < 3.5 since isFALSE was introduced in 3.5. Is your intent to no longer support older version of R or is this an error?

Either way, I am happy to create a pull request bumping the minimum support R version or removing the call to isFALSE. I am using units for the yggdrasil package and noticed the error on CI jobs during a release today.
@edzer
Copy link
Member

edzer commented Mar 16, 2020

No, that was not intentional - PR welcome!

@Enchufa2
Copy link
Member

Enchufa2 commented Mar 16, 2020 •
edited
Loading

Ah, my fault! I was cleaning up some code, and implemented a comment. So that's why it was commented out...

@Enchufa2
Copy link
Member

So maybe it's better to go back to the previous (ugly) version? 7104d48#diff-fced1b4101ae6d6ac8c90b136248b886L128

@Enchufa2
Copy link
Member

BTW, why isn't Travis checking with oldrel?

@langmm langmm mentioned this issue Mar 16, 2020
Merged
langmm added a commit to cropsinsilico/yggdrasil that referenced this issue Mar 17, 2020
@langmm
Attempt to pin units to 0.6-5 until r-quantities/units#229 is resolved
f567ae1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove use of isFALSE to allow use of R < 3.5 langmm/units
3 participants
@edzer @Enchufa2 @langmm