-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only update changed collate #325
Conversation
Fix unnecessary DESCRIPTION overwrite (+ unit test)
I don't think we need to tackle the parallel loading in general. I believe that for plain R packages it should be enough to ensure that no files is changed if not necessary. The use case is that the package has first been loaded by |
Could you please add a bullet point to NEWS? |
…entry when changes are found.
Bullet point about |
Can you please put the NEWS under the top-most bullet point? (should be under 4.1.1.9000) (and similarly for your other PR) |
NEWS entries moved. |
Thanks! |
Hi @hadley
This pull request relates to devtools issue r-lib/devtools#723
@renozao neatened up my first quick fix to make
update_collate
rewrite the Collate entry in the DESCRIPTION file only when roxgyen2 finds changes generated by#' @includes
in the package. He also wrote a unit test as well.This code won't guarantee that devtools can run safely in parallel (that's a much bigger job I think) but I think it will resolve the use case which generated the devtools issue (or at least return control of the problem to anyone running multiple
load_all
s at the same time on a package)Happy to respond to any changes you'd like made. Thanks in advance for looking over this.