Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unnecessary DESCRIPTION overwrite (+ unit test) #1

Merged
merged 1 commit into from
Feb 25, 2015

Conversation

renozao
Copy link

@renozao renozao commented Feb 25, 2015

The changes on R/roclet-collate.R are optional: they only make the function simpler, without the need to write a temporary DESCRIPTION file.

Geoff99 added a commit that referenced this pull request Feb 25, 2015
Fix unnecessary DESCRIPTION overwrite (+ unit test)
@Geoff99 Geoff99 merged commit 84f48a8 into Geoff99:only-update-changed-collate Feb 25, 2015
@Geoff99
Copy link
Owner

Geoff99 commented Feb 25, 2015

Thanks @renozao

Your change to update_collate makes it neater - I didn't like writing out and re-reading the DESCRIPTION file to get the format write - but it was quick and sure to get the same format even if read.description or write.description changed.

I feel much happier having a unit test as well. It doesn't guarantee devtools::load_all will always be safe to run in parallel --- for example if there is a change in the Collate field for the package which is being load_alled, but at least you, as the package owner would have control over that.

I'll submit the merged branch upstream to the official roxygen for Hadley to look over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants