Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look into bad HTML generation for R6 methods #1371

Closed
hadley opened this issue Jun 24, 2022 · 1 comment · Fixed by #1387
Closed

Look into bad HTML generation for R6 methods #1371

hadley opened this issue Jun 24, 2022 · 1 comment · Fixed by #1387
Assignees
Labels
bug an unexpected problem or unintended behavior R6 6️⃣
Milestone

Comments

@hadley
Copy link
Member

hadley commented Jun 24, 2022

From Kurt:

  GauPro D2MCS DoubleML poems

we get Rd files containing

***********************************************************
\if{html}{\out{
<details open><summary>Inherited methods</summary>
<ul>
</ul>
</details>
}}
***********************************************************

apparently from

 c("\\if{html}{\\out{", details,
   "<ul>",
   sprintf(
     paste0(
       "<li>",
       "<span class=\"pkg-link\" data-pkg=\"%s\" data-topic=\"%s\" data-id=\"%s\">",
       "<a href='../../%s/html/%s.html#method-%s-%s'><code>%s::%s$%s()</code></a>",
       "</span>",
       "</li>"
     ),
     super_meth$package,
     super_meth$classname,
     super_meth$name,
     super_meth$package,
     super_meth$classname,
     super_meth$classname,
     super_meth$name,
     super_meth$package,
     super_meth$classname,
     super_meth$name
   ),
   "</ul>",
   "</details>",
   "}}"
 )

in rd-r6.R when super_meth is empty? Not sure whether this is a
problem in the packages? Btw, the current CRAN versions have

@gaborcsardi would you mind taking a look?

@gaborcsardi gaborcsardi self-assigned this Jun 24, 2022
@gaborcsardi
Copy link
Member

Reprex in poems, in GenericModel.Rd.

@hadley hadley added bug an unexpected problem or unintended behavior R6 6️⃣ labels Jun 24, 2022
@hadley hadley added this to the 7.2.1 milestone Jun 24, 2022
hadley added a commit that referenced this issue Jul 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug an unexpected problem or unintended behavior R6 6️⃣
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants