Only show inherited methods if they exist

Fixes #1371
r-lib · Jul 10, 2022 · 764c1d5 · 764c1d5
1 parent f5d8c0a
commit 764c1d5
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 7 deletions.
diff --git a/R/rd-r6.R b/R/rd-r6.R
@@ -258,9 +258,11 @@ r6_inherited_method_list <- function(block, r6data) {
   self <- r6data$self
   super_meth <- super_meth[! super_meth$name %in% self$name, ]
   super_meth <- super_meth[! duplicated(super_meth$name), ]
+  if (nrow(super_meth) == 0) {
+    return()
+  }
 
   super_meth <- super_meth[rev(seq_len(nrow(super_meth))), ]
-
   details <- paste0(
     "<details",
     if (nrow(super_meth) <= 5) " open",

diff --git a/tests/testthat/_snaps/rd-r6.md b/tests/testthat/_snaps/rd-r6.md
@@ -28,12 +28,6 @@
       \item \href{#method-C2-meth1}{\code{C2$meth1()}}
       }
       }
-      \if{html}{\out{
-      <details open><summary>Inherited methods</summary>
-      <ul>
-      </ul>
-      </details>
-      }}
       \if{html}{\out{<hr>}}
       \if{html}{\out{<a id="method-C2-meth1"></a>}}
       \if{latex}{\out{\hypertarget{method-C2-meth1}{}}}