Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default bitbucket credentials for bitbucket dependencies #348

Merged
merged 4 commits into from
Jun 3, 2019
+5 −4
Merged

Use default bitbucket credentials for bitbucket dependencies #348

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ca0f3bc
Merge pull request #4 from r-lib/master
antoine-sachet Apr 10, 2019
4dce6b6
Fix #347
antoine-sachet Apr 10, 2019
73d16e1
Updated NEWS
antoine-sachet Apr 10, 2019
4b4ab15
Merge branch 'master' into fix/bitbucket-deps-credentials
jimhester Jun 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions NEWS.md
View file
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
# remotes (development version)

# remotes 2.0.4
* Bitbucket dependencies now actually use the `BITBUCKET_USER` and
`BITBUCKET_PASSWORD` environment variables (@antoine-sachet, #347).

# remotes (development version)
# remotes 2.0.4

* Fix bug in internal `parse_deps()` where test of valid comparison operators
failed due to trailing whitespaces in DESCRIPTION fields (@LiNk-NY, #366)
4 changes: 2 additions & 2 deletions R/install-bitbucket.R
View file
Original file line number Diff line number Diff line change
@@ -74,8 +74,8 @@ install_bitbucket <- function(repo, ref = "master", subdir = NULL,
}

bitbucket_remote <- function(repo, ref = "master", subdir = NULL,
auth_user = NULL, password = NULL, sha = NULL,
host = "api.bitbucket.org/2.0", ...) {
auth_user = bitbucket_user(), password = bitbucket_password(),
sha = NULL, host = "api.bitbucket.org/2.0", ...) {

meta <- parse_git_repo(repo)