Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default bitbucket credentials for bitbucket dependencies #348

Merged

Conversation

antoine-sachet
Copy link
Contributor

@antoine-sachet antoine-sachet commented Apr 10, 2019

Fix #347. Complement PR #344.

Until this is merged, there is no way to install a private bitbucket dependency since credentials are no longer passed to dependencies. We need the dependencies to use the environment variables.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
update fork
@meztez
Copy link

meztez commented May 10, 2019

We are also experiencing the same behavior and I came to the same conclusion as you, hopefully we can sort his out.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@jimhester jimhester merged commit 2b1c0f4 into r-lib:master Jun 3, 2019
@jimhester
Copy link
Member

Great work, this package is now better thanks to you!

Thanks!! You are da bomb!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bitbucket dependencies should use credentials from environment variables
3 participants