Skip to content
This repository has been archived by the owner on Jun 28, 2021. It is now read-only.

Improved time to first paint #599

Merged
merged 1 commit into from
Jan 20, 2017
Merged

Improved time to first paint #599

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,13 +84,12 @@ module.exports = Object.assign({
{ rel: 'apple-touch-icon', sizes: '152x152', href: '/apple-touch-icon-152x152.png' },
{ rel: 'apple-touch-icon', sizes: '180x180', href: '/apple-touch-icon-180x180.png' },
{ rel: 'preconnect', href: 'https://quran-1f14.kxcdn.com', crossOrigin: '' },
{ rel: 'preconnect', href: 'https://assets-1f14.kxcdn.com', crossOrigin: '' },
{ rel: 'stylesheet', href: 'https://maxcdn.bootstrapcdn.com/font-awesome/4.6.3/css/font-awesome.min.css' }
{ rel: 'preconnect', href: 'https://assets-1f14.kxcdn.com', crossOrigin: '' }
],
/* SEO: https://developers.google.com/structured-data/slsb-overview#markup_examples */
/* SEO: https://developers.google.com/structured-data/site-name#markup_requirements */
script: [
{ src: 'https://cdn.polyfill.io/v2/polyfill.min.js?features=Intl.~locale.en' },
{ src: 'https://cdn.polyfill.io/v2/polyfill.min.js?features=Intl.~locale.en', async: '', defer: '' },
{
type: 'application/ld+json',
innerHTML: `{
Expand Down
3 changes: 3 additions & 0 deletions src/helpers/Html.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,9 @@ const Html = ({ store, component, assets }) => {
{Object.keys(assets.javascript).map((script, i) =>
<script src={assets.javascript[script]} key={i} />
)}
{
<link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/font-awesome/4.6.3/css/font-awesome.min.css" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm i thought links should always be in head?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No it can be anywhere in page. We can move all no critical css and js to bottom of page to improve rendering

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should remove font-awesome since I think it's only used in one place

}
</body>
</html>
);
Expand Down
1 change: 0 additions & 1 deletion src/styles/variables.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ $tracker-height-hundred-boolean: false;

$font-family-sans-serif: 'Montserrat', sans-serif;
$font-montserrat: $font-family-sans-serif;
$font-awesome: 'FontAwesome', serif;
$icon-font-path: "bootstrap-sass/assets/fonts";

@import "node_modules/bootstrap-sass/assets/stylesheets/bootstrap/variables";