This repository has been archived by the owner on Jun 28, 2021. It is now read-only.
Improved time to first paint #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deployed to: http://staging.quran.com:33176 |
mmahalwy
approved these changes
Jan 20, 2017
| @@ -79,6 +79,9 @@ const Html = ({ store, component, assets }) => { | |||
| {Object.keys(assets.javascript).map((script, i) => | |||
| <script src={assets.javascript[script]} key={i} /> | |||
| )} | |||
| { | |||
| <link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/font-awesome/4.6.3/css/font-awesome.min.css" /> | |||
There was a problem hiding this comment.
hmm i thought links should always be in head?
There was a problem hiding this comment.
No it can be anywhere in page. We can move all no critical css and js to bottom of page to improve rendering
There was a problem hiding this comment.
I think we should remove font-awesome since I think it's only used in one place
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
intl pollyfil should included before our main js, opening pr for testing the impact of moving js into bottom.