Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert Translation Matching Logic to Use FileName #581

Merged
merged 2 commits into from
Nov 8, 2023
Merged

Revert Translation Matching Logic to Use FileName #581

merged 2 commits into from
Nov 8, 2023

Commits on Nov 8, 2023

  1. Revert "Use ID for translation diff instead of fileName (#526)" 

    This reverts commit 4091557.

Translation.ID changes every time a db upgrade happens. Instead,
we use fileName as it will not change across upgrades.
    @mohamede1945
    mohamede1945 committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    56d8864 View commit details
    Browse the repository at this point in the history

  2. Delete local translation and insert a new one 

    As we cannot change the Id of the translation through UPDATE query.
    @mohamede1945
    mohamede1945 committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    27329aa View commit details
    Browse the repository at this point in the history