Revert Translation Matching Logic to Use FileName #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4091557. Translation.ID changes every time a db upgrade happens. Instead, we use fileName as it will not change across upgrades.
As we cannot change the Id of the translation through UPDATE query.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #581 +/- ##
==========================================
+ Coverage 41.26% 41.39% +0.13%
==========================================
Files 496 496
Lines 19052 19058 +6
==========================================
+ Hits 7862 7890 +28
+ Misses 11190 11168 -22
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request reverts a recent change (#526) in the matching logic of translations from using
Translation.IdtofileName. The update was initially implemented to enhance the accuracy of translation matching. However, it was observed that new versions of the same translation are assigned new IDs, leading to inconsistencies in the matching process.Issue
After updating the matching logic to utilize
Translation.Id, we encountered a significant issue where new versions of translations received different IDs, breaking the expected continuity and leading to mismatches in our application. This behavior was not anticipated and has affected the stability of the translation matching feature.Resolution
To address this, we've decided to revert to using the
fileNameas the matching reference. ThefileNamehas been confirmed with the backend team to be a stable and unchanging field, ensuring consistent matching even when new versions of translations are released.Testing
The changes have been tested locally, and existing automated tests have been updated to reflect this new logic. Manual testing was also conducted to ensure that translations are being matched correctly with their respective
fileName.