Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Disable auto-unsupported for single server/client tests #393

Merged
merged 2 commits into from
Nov 6, 2024
Merged

fix: Disable auto-unsupported for single server/client tests #393

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c83399
fix: Disable auto-unsupported for single server/client tests
larseggert Jul 18, 2024
d31fa54
Change logic
larseggert Nov 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 21 additions & 19 deletions interop.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,27 +180,29 @@ def _check_impl_is_compliant(self, name: str) -> bool:
def _postprocess_results(self):
clients = list(set(client for client, _ in self._client_server_pairs))
servers = list(set(server for _, server in self._client_server_pairs))
# If a client failed a test against all servers, make the test unsupported for the client
questionable = [TestResult.FAILED, TestResult.UNSUPPORTED]
for c in set(clients) - set(self._no_auto_unsupported):
for t in self._tests:
if all(self.test_results[s][c][t] in questionable for s in servers):
print(
f'Client {c} failed test "{t.name()}" against all servers, '
+ 'marking the entire test as "unsupported"'
)
for s in servers:
self.test_results[s][c][t] = TestResult.UNSUPPORTED
# If a client failed a test against all servers, make the test unsupported for the client
if len(servers) > 1:
for c in set(clients) - set(self._no_auto_unsupported):
for t in self._tests:
if all(self.test_results[s][c][t] in questionable for s in servers):
print(
f"Client {c} failed or did not support test {t.name()} "
+ 'against all servers, marking the entire test as "unsupported"'
)
for s in servers:
self.test_results[s][c][t] = TestResult.UNSUPPORTED
# If a server failed a test against all clients, make the test unsupported for the server
for s in set(servers) - set(self._no_auto_unsupported):
for t in self._tests:
if all(self.test_results[s][c][t] in questionable for c in clients):
print(
f'Server {s} failed test "{t.name()}" against all clients, '
+ 'marking the entire test as "unsupported"'
)
for c in clients:
self.test_results[s][c][t] = TestResult.UNSUPPORTED
if len(clients) > 1:
for s in set(servers) - set(self._no_auto_unsupported):
for t in self._tests:
if all(self.test_results[s][c][t] in questionable for c in clients):
print(
f"Server {s} failed or did not support test {t.name()} "
+ 'against all clients, marking the entire test as "unsupported"'
)
for c in clients:
self.test_results[s][c][t] = TestResult.UNSUPPORTED

def _print_results(self):
"""print the interop table"""
Expand Down
Loading