fix: Disable auto-unsupported for single server/client tests #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marten-seemann
approved these changes
Jul 22, 2024
|
Hello Marten @marten-seemann, could this PR be merged please? It will help the case where there's just one client and currently without the changes in this PR any failure is marked as unsupported, thus burying any real issues that need investigation. |
It doesn't make sense to automatically claim a test as unsupported if we're only testing a single implementation.
larseggert
force-pushed
the
fix-no-autounsupp-single-impl
branch
from
d073aed to
d31fa54
Compare
|
@marten-seemann this is ready from my side. |
|
It would be really nice to have a unit test for this logic. How much work with that be, if you use your favorite LLM to come up with something? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't make sense to automatically claim a test as unsupported if we're only testing a single implementation.