fix(schema/definitions.yml): Giscus light/dark theme YAML key is missing
#10005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcanouil
changed the title
mcanouil
changed the title
theme YAML key is missing
cderv
approved these changes
Jun 14, 2024
There was a problem hiding this comment.
Thanks !
FYI, quarto build-js was not ran for a change related to "Enables tabsets to present content.".
Wrong assumption. It was ran - See #9916
It is just sometimes when you re-run it could reorganized it seems.
Anyhow, does not matter much.
Thank you !
|
The order is not deterministic, I assumed it was. Spurious diff welcome^^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Giscus light/dark theme yaml example in the documentation is incorrect. This pull request fixes the example by updating the YAML structure to include a
themekey underwebsite.comments.giscus. Thethemekey contains thelightanddarkthemes for the Giscus comments. This change ensures that the documentation accurately reflects the correct YAML structure for configuring Giscus themes.Fixes #10003
FYI,
quarto build-jswas not ran for a change related to"Enables tabsets to present content.".