Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Giscus light/dark theme yaml example incorrect #10003

Closed
ozanozbeker opened this issue Jun 14, 2024 · 1 comment · Fixed by #10005
Closed

Giscus light/dark theme yaml example incorrect #10003

ozanozbeker opened this issue Jun 14, 2024 · 1 comment · Fixed by #10005
Assignees
@mcanouil
Labels
documentation Doc improvements & quarto-web
Milestone
v1.5

Comments

@ozanozbeker
Copy link

What would you like to do?

Report an issue on quarto.org

Description

In the Giscus section, https://quarto.org/docs/reference/projects/websites.html#giscus, the documentation shows:

website:
  comments:
    giscus:
      light: light # giscus theme used for light website theme
      dark: dark_dimmed # giscus theme used for dark website theme

But it should be:

website:
  comments:
    giscus:
      theme:
        light: light # giscus theme used for light website theme
        dark: dark_dimmed # giscus theme used for dark website theme
@ozanozbeker ozanozbeker added the documentation Doc improvements & quarto-web label Jun 14, 2024
@mcanouil mcanouil self-assigned this Jun 14, 2024
@mcanouil mcanouil mentioned this issue Jun 14, 2024
Merged
mcanouil added a commit to mcanouil/quarto-cli that referenced this issue Jun 14, 2024
@mcanouil
fix: Giscus light/dark theme yaml example incorrect
9f48e78 
Fixes quarto-dev#10003
@mcanouil
Copy link
Collaborator

mcanouil commented Jun 14, 2024 •
edited
Loading

Thanks! (PR is up)

@mcanouil mcanouil added this to the v1.5 milestone Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mcanouil mcanouil

Labels
documentation Doc improvements & quarto-web
Projects
None yet
Milestone
v1.5
Development

Successfully merging a pull request may close this issue.

fix(schema/definitions.yml): Giscus light/dark theme YAML key is missing mcanouil/quarto-cli
2 participants
@mcanouil @ozanozbeker