-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ArC - register /quarkus/arc/beans and /quarkus/arc/observers routes in the dev mode #9412
Conversation
I should probably add some tests too. |
extensions/vertx-http/runtime/src/test/java/io/quarkus/vertx/http/runtime/devmode/JsonTest.java
Outdated
Show resolved
Hide resolved
extensions/vertx-http/runtime/src/test/java/io/quarkus/vertx/http/runtime/devmode/JsonTest.java
Outdated
Show resolved
Hide resolved
extensions/vertx-http/runtime/src/main/java/io/quarkus/vertx/http/runtime/devmode/Json.java
Show resolved
Hide resolved
...tx-http/runtime/src/main/java/io/quarkus/vertx/http/runtime/devmode/ArcEndpointRecorder.java
Show resolved
Hide resolved
...tx-http/runtime/src/main/java/io/quarkus/vertx/http/runtime/devmode/ArcEndpointRecorder.java
Show resolved
Hide resolved
...tx-http/runtime/src/main/java/io/quarkus/vertx/http/runtime/devmode/ArcEndpointRecorder.java
Outdated
Show resolved
Hide resolved
...tx-http/runtime/src/main/java/io/quarkus/vertx/http/runtime/devmode/ArcEndpointRecorder.java
Show resolved
Hide resolved
- these routes produce basic debug info in the JSON format
c1c3128
to
9cac700
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a very userful feature, 👍
@mkouba Would it make sense to add a link on the generated "index.html" page to get this page? |
@cescoffier it's not a page but a JSON file. It would probably make sense to provide an html page as well. That's the next step ;-). |
Yes, definitely a next step. But can be cool to have a few ‘debug’ pages: beans, routes... |
Absolutely. This stuff then can also be used by IDEs (cc @maxandersen) |
#2120 is probably related... |
It is yeah :) |
these kind of debug pages - shouldn't we put them under one root, i.e. |
There is an open issue for mgmt endpoints: #2450 +0 for the Also it's not a debug page but a debug endpoint that returns a JSON file ;-). |
you are +0 because of the suggested name or in principle ? and yes #2450 is the same challenge for sure and it doesn't matter if its page or endpoint...its about having things "collected" |
How to use:
mvn quarkus:dev
http://localhost:8080/arc/beans
http://localhost:8080/arc/observers
http://localhost:8080/arc/beans?scope=Singleton
http://localhost:8080/arc/beans?beanClass=org.acme.Foo
http://localhost:8080/arc/beans?kind=PRODUCER_METHOD
This PR also contains a minimalistic JSON generator (
io.quarkus.vertx.http.runtime.devmode.Json
, mainly copied from the Weld Probe) because we can't useio.vertx.core.json.JsonObject/JsonArray
unless thequarkus-jackson-databind
extension is in.