-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce configurable management endpoint prefix #2450
Comments
I'm not sure it's a good idea. E.g. https://prometheus.io/docs/introduction/first_steps/ : https://prometheus.io/docs/prometheus/latest/configuration/configuration/#static_config … just host and port can be specified MP users are used to standard path at root, they can have tooling around those endpoints. |
While there are certainly tools that expect certain endpoints at root, they can also be configured to use different paths. Whatever is done here needs to be configurable such that a user can choose whether endpoints go under |
+1 to have configuration option for MP-related and (eventually) Quarkus-specific endpoints at root
|
Could we have another port for internal resource ? like metrics or health ? So we could use it for local parse (like kubernetes probes or pronmetheus scrape) and just expose the user resources with another port ? |
I think it makes for "management endpoints" to have a configurable path and port. |
Spring Boot 2 also scopes endpoints, placing them under an I don't know how common it is to separate health/prometheus endpoints on different ports. Yes, it could be configurable, but I don't think it is very common in practice. With Kubernetes, Prometheus endpoints are discovered dynamically, which removes the static/global configuration worry: https://prometheus.io/docs/prometheus/latest/configuration/configuration/#kubernetes_sd_config (sorry, stumbled on this really old issue from conversation in Zulip..) |
Should this now be closed with the advent of |
I believe it can yeah |
Based on the Avoid polluting the URI namespace with Quarkus endpoints thread.
The prefix should be
/quarkus
by default.All extensions that expose non-app endpoints should use this prefix:
/quarkus/health
,/quarkus/open-api
, etc.The text was updated successfully, but these errors were encountered: