Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename SA_PASSWORD to MSSQL_SA_PASSWORD as SA_PASSWORD is deprecated #42102

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Rename SA_PASSWORD to MSSQL_SA_PASSWORD as SA_PASSWORD is deprecated #42102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion extensions/reactive-mssql-client/deployment/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@
</ports>
<env>
<ACCEPT_EULA>Y</ACCEPT_EULA>
<SA_PASSWORD>yourStrong(!)Password</SA_PASSWORD>
<MSSQL_SA_PASSWORD>yourStrong(!)Password</MSSQL_SA_PASSWORD>
</env>
<log>
<prefix>MSSQL:</prefix>
Expand Down
2 changes: 1 addition & 1 deletion integration-tests/hibernate-reactive-mssql/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@
</ports>
<env>
<ACCEPT_EULA>Y</ACCEPT_EULA>
<SA_PASSWORD>yourStrong(!)Password</SA_PASSWORD>
<MSSQL_SA_PASSWORD>yourStrong(!)Password</MSSQL_SA_PASSWORD>
</env>
<log>
<prefix>MS SQL Server:</prefix>
Expand Down
2 changes: 1 addition & 1 deletion integration-tests/jpa-mssql/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ you'll probably want to change the authentication password too: `-Dmssqldb.sa-pa
If you prefer to run the MSSQL Server container via podman, use:

```
podman run --rm=true --net=host --memory-swappiness=0 --name mssql_testing -e SA_PASSWORD=yourStrong(!)Password -e ACCEPT_EULA=Y -p 1435:1433 mcr.microsoft.com/mssql/2022-latest
podman run --rm=true --net=host --memory-swappiness=0 --name mssql_testing -e MSSQL_SA_PASSWORD=yourStrong(!)Password -e ACCEPT_EULA=Y -p 1435:1433 mcr.microsoft.com/mssql/2022-latest
```

## Limitations
Expand Down
2 changes: 1 addition & 1 deletion integration-tests/jpa-mssql/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@
</ports>
<env>
<ACCEPT_EULA>Y</ACCEPT_EULA>
<SA_PASSWORD>yourStrong(!)Password</SA_PASSWORD>
<MSSQL_SA_PASSWORD>yourStrong(!)Password</MSSQL_SA_PASSWORD>
</env>
<log>
<prefix>MS SQL Server:</prefix>
Expand Down
2 changes: 1 addition & 1 deletion integration-tests/reactive-mssql-client/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@
</ports>
<env>
<ACCEPT_EULA>Y</ACCEPT_EULA>
<SA_PASSWORD>yourStrong(!)Password</SA_PASSWORD>
<MSSQL_SA_PASSWORD>yourStrong(!)Password</MSSQL_SA_PASSWORD>
</env>
<log>
<prefix>MSSQL:</prefix>
Expand Down