Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename SA_PASSWORD to MSSQL_SA_PASSWORD as SA_PASSWORD is deprecated #42102

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

jedla97
Copy link
Contributor

@jedla97 jedla97 commented Jul 24, 2024

@quarkus-bot
Copy link

quarkus-bot bot commented Jul 24, 2024

/cc @gsmet (hibernate-orm), @yrodiere (hibernate-orm)

Copy link
Member

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

From what I can see it should work on both SQL Server 2022 and azure-sql-edge:latest (used for Mac M1 testing)

I checked dev services, and there the environment variable is set by testcontainers itself, so we can let them do the update (no idea if they already did).

@quarkus-bot
Copy link

quarkus-bot bot commented Jul 24, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 9cd76a0.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@jedla97
Copy link
Contributor Author

jedla97 commented Jul 24, 2024

Thanks for looking into it. What I was looking at docs for MSSQL 2017 the SA_PASSWORD note is also there and I was able to start docker image with the MSSQL_SA_PASSWORD so this probably happend long time ago but both still work.

Looking at the testcointainers repo they still using old https://github.com/testcontainers/testcontainers-java/blob/main/modules/mssqlserver/src/main/java/org/testcontainers/containers/MSSQLServerContainer.java#L81

@yrodiere yrodiere merged commit 0a4a366 into quarkusio:main Jul 24, 2024
20 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.14 - main milestone Jul 24, 2024
@jedla97 jedla97 deleted the mssql-password branch July 24, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants