[3.15] Backports #2082

fedinskiy · 2024-10-10T11:45:02Z

Summary

Backports these PRs:

Please select the relevant options.

Bug fix (non-breaking change which fixes an issue)
Dependency update
Refactoring
Backport
New scenario (non-breaking change which adds functionality)
This change requires a documentation update
This change requires execution against OCP (use run tests phrase in comment)

Checklist:

Methods and classes used in PR scenarios are meaningful
Commits are well encapsulated and follow the best practices

Following the recommendation from quarkusio/quarkus#43360 (cherry picked from commit 64f9986)

fedinskiy · 2024-10-10T11:45:21Z

run tests

michalvavrik

LGTM

michalvavrik · 2024-10-10T13:54:47Z

@fedinskiy I think you need to check the Kafka failure

fedinskiy · 2024-10-10T14:13:31Z

@michalvavrik it is backport of your commit (#2060) Any idea, why server.jks may be not generated/found?

michalvavrik · 2024-10-10T14:28:26Z

@michalvavrik it is backport of your commit (#2060) Any idea, why server.jks may be not generated/found?

probably backports are not one to one, let me have a look

michalvavrik · 2024-10-10T14:30:06Z

@fedinskiy had a look, you picked just one of 2 commits https://github.com/quarkus-qe/quarkus-test-suite/pull/2060/commits you need both; it was intentional to have 2 commits

fedinskiy · 2024-10-10T14:34:00Z

@michalvavrik I backported the merge commit (neither 2046096aefd3679d43e241391e9cd0791362966 nor 46b1641d121a565fe365cf5f08b9f590f356a39a are in our main trunk)

michalvavrik · 2024-10-10T14:35:29Z

@michalvavrik I backported the merge commit (neither 2046096aefd3679d43e241391e9cd0791362966 nor 46b1641d121a565fe365cf5f08b9f590f356a39a are in our main trunk)

in that case commit title is wrong. in any case, this only happens when commits doesn't apply, I'll report back

(cherry picked from commit c9f76ae)

(cherry picked from commit d7546bd)

…image This was discoverd with IBM testing and fixed for 3.8 branch in quarkus-qe#2004 (cherry picked from commit b6e1406)

(cherry picked from commit 47c9d88)

We have --stream parameter enabled everywhere by default, but this behavior conflicts with --platform option, we use in several tests (cherry picked from commit 9aa05cb)

michalvavrik · 2024-10-10T14:43:24Z

I still see a difference between these commits. In the main branch PR https://github.com/quarkus-qe/quarkus-test-suite/pull/2060/files I can see kafkaSSL/src/main/java that are completely missing in this PR. Without these changes it cannot work properly.

fedinskiy · 2024-10-10T14:46:21Z

@michalvavrik it looks like github API returns only the last commit id sometimes, if there were several of them. I think I did the proper backport now, Let's try CI again

michalvavrik · 2024-10-10T14:48:32Z

sure, thanks

fedinskiy · 2024-10-10T14:51:33Z

run tests

github-actions · 2024-10-10T16:10:04Z

Unknown format for flaky report filename: flaky-run-report.json
Following jobs contain at least one flaky test:

PR - Linux - JVM build - Latest Version

Run summary: https://github.com/quarkus-qe/quarkus-test-suite/actions/runs/11276415589?pr=2082

Flaky tests:

io.quarkus.ts.messaging.kafka.reactive.streams.KafkaGratefulShutdownIT.testConnection

Failure message: Assertion condition defined as a Lambda expression in io.quarkus.test.utils.LogsVerifier Log does not contain any of '[ave]'. Full logs: [__ ____ __ _____ ___ __ ____ ______ , --/ __ \/ / / / _ | / _ \/ //_/ / / / __/ , -/ /_/ / /_/ / __ |/ , _/ ,< / /_/ /\ \ , --\___\_\____/_/ |_/_/|_/_/|_|\____/___/ , 15:47:40,010 SRMSG18229: Configured topics for channel 'slow': [slow], 15:47:40,025 SRMSG18214: Key deserializer omitted, using String as default, 15:47:40,025 SRMSG18234: Auto-commit disabled for channel slow, 15:47:40,205 SRMSG18240: 'throttled' commit strategy used for channel 'slow', 15:47:40,206 SRMSG18232: Will commit for group 'kafka-streams-reactive-messaging' every 5000 milliseconds., 15:47:40,206 SRMSG18236: Will mark throttled commit strategy for group 'kafka-streams-reactive-messaging' as unhealthy if records go more than 60000 milliseconds without being processed., 15:47:40,237 SRMSG18248: Key serializer omitted, using String as default, 15:47:40,264 SRMSG18258: Kafka producer kafka-producer-slow-topic, connected to Kafka brokers 'localhost:32794', is configured to write records to 'slow', 15:47:40,315 SRMSG18257: Kafka consumer kafka-consumer-slow, connected to Kafka brokers 'localhost:32794', belongs to the 'kafka-streams-reactive-messaging' consumer group and is configured to poll records from [slow], 15:47:40,319 No Topology producer; Kafka Streams will not be started, 15:47:40,413 kafka-streams-reactive-messaging 1.0.0-SNAPSHOT on JVM (powered by Quarkus 3.15.999-SNAPSHOT) started in 1.358s. Listening on: http://0.0.0.0:1104, 15:47:40,413 Profile prod activated. , 15:47:40,413 Installed features: [cdi, kafka-client, kafka-streams, messaging, messaging-kafka, resteasy, resteasy-jsonb, smallrye-context-propagation, vertx], 15:47:40,535 [Consumer clientId=kafka-consumer-slow, groupId=kafka-streams-reactive-messaging] Error while fetching metadata with correlation id 2 : {slow=UNKNOWN_TOPIC_OR_PARTITION}, 15:47:44,016 SRMSG18209: Sending message org.eclipse.microprofile.reactive.messaging.Message$5@75609bc8 from channel 'slow-topic' to Kafka topic 'slow', 15:47:44,108 SRMSG18211: Message org.eclipse.microprofile.reactive.messaging.Message$5@75609bc8 from channel 'slow-topic' sent successfully to Kafka topic-partition 'slow-0', with offset 0] ==> expected: <true> but was: <false> within 30 seconds.
Failed in jobs:
- flaky-run-report.json

Failure stacktrace

org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a Lambda expression in io.quarkus.test.utils.LogsVerifier Log does not contain any of '[ave]'. Full logs: [__  ____  __  _____   ___  __ ____  ______ ,  --/ __ \/ / / / _ | / _ \/ //_/ / / / __/ ,  -/ /_/ / /_/ / __ |/ , _/ ,< / /_/ /\ \   , --\___\_\____/_/ |_/_/|_/_/|_|\____/___/   , 15:47:40,010 SRMSG18229: Configured topics for channel 'slow': [slow], 15:47:40,025 SRMSG18214: Key deserializer omitted, using String as default, 15:47:40,025 SRMSG18234: Auto-commit disabled for channel slow, 15:47:40,205 SRMSG18240: 'throttled' commit strategy used for channel 'slow', 15:47:40,206 SRMSG18232: Will commit for group 'kafka-streams-reactive-messaging' every 5000 milliseconds., 15:47:40,206 SRMSG18236: Will mark throttled commit strategy for group 'kafka-streams-reactive-messaging' as unhealthy if records go more than 60000 milliseconds without being processed., 15:47:40,237 SRMSG18248: Key serializer omitted, using String as default, 15:47:40,264 SRMSG18258: Kafka producer kafka-producer-slow-topic, connected to Kafka brokers 'localhost:32794', is configured to write records to 'slow', 15:47:40,315 SRMSG18257: Kafka consumer kafka-consumer-slow, connected to Kafka brokers 'localhost:32794', belongs to the 'kafka-streams-reactive-messaging' consumer group and is configured to poll records from [slow], 15:47:40,319 No Topology producer; Kafka Streams will not be started, 15:47:40,413 kafka-streams-reactive-messaging 1.0.0-SNAPSHOT on JVM (powered by Quarkus 3.15.999-SNAPSHOT) started in 1.358s. Listening on: http://0.0.0.0:1104, 15:47:40,413 Profile prod activated. , 15:47:40,413 Installed features: [cdi, kafka-client, kafka-streams, messaging, messaging-kafka, resteasy, resteasy-jsonb, smallrye-context-propagation, vertx], 15:47:40,535 [Consumer clientId=kafka-consumer-slow, groupId=kafka-streams-reactive-messaging] Error while fetching metadata with correlation id 2 : {slow=UNKNOWN_TOPIC_OR_PARTITION}, 15:47:44,016 SRMSG18209: Sending message org.eclipse.microprofile.reactive.messaging.Message$5@75609bc8 from channel 'slow-topic' to Kafka topic 'slow', 15:47:44,108 SRMSG18211: Message org.eclipse.microprofile.reactive.messaging.Message$5@75609bc8 from channel 'slow-topic' sent successfully to Kafka topic-partition 'slow-0', with offset 0] ==> expected: <true> but was: <false> within 30 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.untilAsserted(ConditionFactory.java:790)
	at io.quarkus.test.utils.AwaitilityUtils.untilAsserted(AwaitilityUtils.java:134)
	at io.quarkus.test.utils.AwaitilityUtils.untilAsserted(AwaitilityUtils.java:124)
	at io.quarkus.test.utils.LogsVerifier.assertContains(LogsVerifier.java:28)
	at io.quarkus.ts.messaging.kafka.reactive.streams.KafkaGratefulShutdownIT.testConnection(KafkaGratefulShutdownIT.java:71)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
Caused by: org.opentest4j.AssertionFailedError: Log does not contain any of '[ave]'. Full logs: [__  ____  __  _____   ___  __ ____  ______ ,  --/ __ \/ / / / _ | / _ \/ //_/ / / / __/ ,  -/ /_/ / /_/ / __ |/ , _/ ,< / /_/ /\ \   , --\___\_\____/_/ |_/_/|_/_/|_|\____/___/   , 15:47:40,010 SRMSG18229: Configured topics for channel 'slow': [slow], 15:47:40,025 SRMSG18214: Key deserializer omitted, using String as default, 15:47:40,025 SRMSG18234: Auto-commit disabled for channel slow, 15:47:40,205 SRMSG18240: 'throttled' commit strategy used for channel 'slow', 15:47:40,206 SRMSG18232: Will commit for group 'kafka-streams-reactive-messaging' every 5000 milliseconds., 15:47:40,206 SRMSG18236: Will mark throttled commit strategy for group 'kafka-streams-reactive-messaging' as unhealthy if records go more than 60000 milliseconds without being processed., 15:47:40,237 SRMSG18248: Key serializer omitted, using String as default, 15:47:40,264 SRMSG18258: Kafka producer kafka-producer-slow-topic, connected to Kafka brokers 'localhost:32794', is configured to write records to 'slow', 15:47:40,315 SRMSG18257: Kafka consumer kafka-consumer-slow, connected to Kafka brokers 'localhost:32794', belongs to the 'kafka-streams-reactive-messaging' consumer group and is configured to poll records from [slow], 15:47:40,319 No Topology producer; Kafka Streams will not be started, 15:47:40,413 kafka-streams-reactive-messaging 1.0.0-SNAPSHOT on JVM (powered by Quarkus 3.15.999-SNAPSHOT) started in 1.358s. Listening on: http://0.0.0.0:1104, 15:47:40,413 Profile prod activated. , 15:47:40,413 Installed features: [cdi, kafka-client, kafka-streams, messaging, messaging-kafka, resteasy, resteasy-jsonb, smallrye-context-propagation, vertx], 15:47:40,535 [Consumer clientId=kafka-consumer-slow, groupId=kafka-streams-reactive-messaging] Error while fetching metadata with correlation id 2 : {slow=UNKNOWN_TOPIC_OR_PARTITION}, 15:47:44,016 SRMSG18209: Sending message org.eclipse.microprofile.reactive.messaging.Message$5@75609bc8 from channel 'slow-topic' to Kafka topic 'slow', 15:47:44,108 SRMSG18211: Message org.eclipse.microprofile.reactive.messaging.Message$5@75609bc8 from channel 'slow-topic' sent successfully to Kafka topic-partition 'slow-0', with offset 0] ==> expected: <true> but was: <false>
	at io.quarkus.test.utils.LogsVerifier.lambda$assertContains$0(LogsVerifier.java:30)
	at org.awaitility.core.AssertionCondition.lambda$new$0(AssertionCondition.java:53)
	at org.awaitility.core.ConditionAwaiter$ConditionPoller.call(ConditionAwaiter.java:248)
	at org.awaitility.core.ConditionAwaiter$ConditionPoller.call(ConditionAwaiter.java:235)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
	at java.base/java.lang.Thread.run(Thread.java:840)

Enable funqy tests in Native

187c7f5

Following the recommendation from quarkusio/quarkus#43360 (cherry picked from commit 64f9986)

fedinskiy requested a review from michalvavrik October 10, 2024 11:45

fedinskiy self-assigned this Oct 10, 2024

michalvavrik approved these changes Oct 10, 2024

View reviewed changes

mocenas and others added 7 commits October 10, 2024 16:42

Disable SSL requirement for keycloak realms

80a966c

(cherry picked from commit c9f76ae)

Disable OpenShiftDefaultInitContainerIT on aarch64

766133e

(cherry picked from commit d7546bd)

Fix PostgresqlResource which failing to start when using RH postgres …

fb4f81f

…image This was discoverd with IBM testing and fixed for 3.8 branch in quarkus-qe#2004 (cherry picked from commit b6e1406)

Disable kafka streams test also on quarkus main aarch native

fc22708

(cherry picked from commit 47c9d88)

Fix failures in CLI

f966772

We have --stream parameter enabled everywhere by default, but this behavior conflicts with --platform option, we use in several tests (cherry picked from commit 9aa05cb)

Kafka TLS registry test coverage

700c52a

Test TLS registry manual trigger of cert reloading

29fbd81

fedinskiy force-pushed the backports/10.10 branch from b3b7eb2 to 29fbd81 Compare October 10, 2024 14:44

github-actions bot added the triage/flaky-test Signal that flaky tests were detected during CI run label Oct 10, 2024

michalvavrik merged commit fe3768d into quarkus-qe:3.15 Oct 10, 2024
10 checks passed

fedinskiy deleted the backports/10.10 branch October 11, 2024 06:52

michalvavrik removed the triage/flaky-test Signal that flaky tests were detected during CI run label Nov 21, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[3.15] Backports #2082

[3.15] Backports #2082

fedinskiy commented Oct 10, 2024

fedinskiy commented Oct 10, 2024

michalvavrik left a comment

michalvavrik commented Oct 10, 2024

fedinskiy commented Oct 10, 2024

michalvavrik commented Oct 10, 2024

michalvavrik commented Oct 10, 2024

fedinskiy commented Oct 10, 2024

michalvavrik commented Oct 10, 2024

michalvavrik commented Oct 10, 2024

fedinskiy commented Oct 10, 2024

michalvavrik commented Oct 10, 2024

fedinskiy commented Oct 10, 2024

github-actions bot commented Oct 10, 2024

[3.15] Backports #2082

[3.15] Backports #2082

Conversation

fedinskiy commented Oct 10, 2024

Summary

Checklist:

fedinskiy commented Oct 10, 2024

michalvavrik left a comment

Choose a reason for hiding this comment

michalvavrik commented Oct 10, 2024

fedinskiy commented Oct 10, 2024

michalvavrik commented Oct 10, 2024

michalvavrik commented Oct 10, 2024

fedinskiy commented Oct 10, 2024

michalvavrik commented Oct 10, 2024

michalvavrik commented Oct 10, 2024

fedinskiy commented Oct 10, 2024

michalvavrik commented Oct 10, 2024

fedinskiy commented Oct 10, 2024

github-actions bot commented Oct 10, 2024