Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable funqy tests in Native #2059

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Enable funqy tests in Native #2059

merged 1 commit into from
Oct 2, 2024

Conversation

fedinskiy
Copy link
Contributor

Summary

Following the recommendation from quarkusio/quarkus#43360

Please select the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • Dependency update
  • Refactoring
  • Backport
  • New scenario (non-breaking change which adds functionality)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@fedinskiy
Enable funqy tests in Native
64f9986 
Following the recommendation from quarkusio/quarkus#43360
@fedinskiy fedinskiy requested a review from michalvavrik October 2, 2024 09:12
@fedinskiy
Copy link
Contributor Author

run tests

michalvavrik
michalvavrik approved these changes Oct 2, 2024
View reviewed changes
Copy link
Member

@michalvavrik michalvavrik left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not really sure why we have quarkus-openshift and quarkus-openshift-client, my thinking is that I probably made mistake in past to activate it when OpenShift profile is not active. Like, it should be in a specific profile.

Anyway, changes LGTM

@michalvavrik michalvavrik merged commit d0f8ba5 into quarkus-qe:main Oct 2, 2024
10 checks passed
@fedinskiy fedinskiy deleted the fix/funqy branch October 10, 2024 09:32
@fedinskiy fedinskiy mentioned this pull request Oct 10, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalvavrik michalvavrik michalvavrik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fedinskiy @michalvavrik