Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed httpExporter for multipage diagrams #45

Merged
merged 1 commit into from
Jun 22, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,11 @@
"default": "http://www.plantuml.com/plantuml",
"description": "Plantuml server to generate UML diagrams on-the-fly."
},
"plantuml.urlServerIndexParameter": {
"type": "string",
"default": "",
"description": "Optional index parameter name for multipage diagrams. (e.g. uri?idx=${n})"
},
"plantuml.urlFormat": {
"type": "string",
"default": "",
Expand Down
4 changes: 4 additions & 0 deletions src/config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,10 @@ class ConfigReader {
return this._read<string>('urlServer') || "http://www.plantuml.com/plantuml";
}

get urlServerIndexParameter(): string {
return this._read<string>('urlServerIndexParameter');
}

get urlFormat(): string {
return this._read<string>('urlFormat');
}
Expand Down
76 changes: 45 additions & 31 deletions src/httpExporter.ts
Original file line number Diff line number Diff line change
@@ -1,13 +1,11 @@
'use strict';

import * as vscode from 'vscode';

import { Diagram, Diagrams } from './diagram';
import { config } from './config';
import { urlMaker } from './urlMaker';
import { ExportError, ExportTask } from './exporter';
import { localize } from './planuml';

const request = require('request');


class HttpExporter {
Expand All @@ -23,37 +21,53 @@ class HttpExporter {
}

private doExport(diagram: Diagram, format: string): ExportTask {
let pURL = urlMaker.makeURL(diagram, config.urlServer, format, null);

var request = require('request');
// console.log("Exporting preview image from %s", pURL.url);
let pms = new Promise<Buffer>((resolve, reject) => {
let allPms = [...Array(diagram.pageCount).keys()].map(
(index) => {

request(
{ method: 'GET'
, uri: pURL.url
, encoding: null // for byte encoding. Otherwise string.
, gzip: true
}
, function (error, response, body) {
if (!error && response.statusCode === 200) {
resolve(body);
} else {
let stderror;
if (!error) {
stderror = "Unexpected Statuscode: "
+ response.statusCode + "\n"
+ "for GET " + pURL.url;
} else {
stderror = error.message;
body = new Buffer("");
}
stderror = localize(10, null, diagram.title, stderror);
reject(<ExportError>{ error: stderror, out: body });
let requestUrl = urlMaker.makeURL(diagram, config.urlServer, format, null).url;
if (config.urlServerIndexParameter) {
requestUrl += "?" + config.urlServerIndexParameter + "=" + index;
}
})
});
return <ExportTask>{ promise: pms };

let pms = new Promise<Buffer>((resolve, reject) => {

request(
{ method: 'GET'
, uri: requestUrl
, encoding: null // for byte encoding. Otherwise string.
, gzip: true
}
, function (error, response, body) {
if (!error && response.statusCode === 200) {
resolve(body);
} else {
let stderror;
if (!error) {
stderror = "Unexpected Statuscode: "
+ response.statusCode + "\n"
+ "for GET " + requestUrl;
} else {
stderror = error.message;
body = new Buffer("");
}
stderror = localize(10, null, diagram.title, stderror);
reject(<ExportError>{ error: stderror, out: body });
}
})
});
return pms;

},
Promise.resolve(new Buffer(""))
);



return <ExportTask>{
processes: null,
promise: Promise.all(allPms),
}

}
}
Expand Down