Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed httpExporter for multipage diagrams #45

Merged
merged 1 commit into from
Jun 22, 2017
Merged

Fixed httpExporter for multipage diagrams #45

merged 1 commit into from
Jun 22, 2017

Conversation

rado0x54
Copy link
Contributor

Hey qjebbs,

your commit 1043bb1 unfortunately broke the httpExporter Logic as well. I updated the code accordingly.

You can test it against http://plantuml.rado0x54.com:

    "plantuml.urlServer": "http://plantuml.rado0x54.com",
    "plantuml.previewFromUrlServer": true,
    "plantuml.urlServerIndexParameter": "idx"

e.g.
http://plantuml.rado0x54.com/png/IzIrIx9Io4ZDoSctvifBBIz8J4zLWD8bcIKvgLn9kdQ92bOAIOd9sGhvUI0v1P2aDG00?idx=0
&
http://plantuml.rado0x54.com/png/IzIrIx9Io4ZDoSctvifBBIz8J4zLWD8bcIKvgLn9kdQ92bOAIOd9sGhvUI0v1P2aDG00?idx=1

Quick release would be appreciated.

@qjebbs qjebbs merged commit 054b54f into qjebbs:master Jun 22, 2017
@qjebbs
Copy link
Owner

qjebbs commented Jun 22, 2017

Thank you. And SORRY for my mistake.

@rado0x54
Copy link
Contributor Author

No problem, Thank you for the quick release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rado0x54 @qjebbs