795 conda env python3 10 #807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se collections.abc.
* 795 conda env python3 10 using updated tag from pyepr (#796) * Callable from collections is depreicated for python 3.10 so need to use collections.abc. * Add new tag for pyepr. * Update tags for new Metal pypi release. * Wait until Samarth s pull request is merged. * To make run_all_tests to pass. @GyeongHun had the fix. * Use later tag. * Implement Ability to Extract Q-factors from Eigenmode Simulations (#794) * Implement Ability to Extract Q-factors from Eigenmode Simulations * Updated tests * Added Tutorial * Revert "Updated tests" This reverts commit 146b0e9. Tests would be restored to the one in main. * When one plot_convergences(), then the frequiences are gathered so they gotten by get_frequencies(). * Removed solution_type variable. Replaced by pyEPR implementation * Updated tests Co-authored-by: Priti Ashvin Shah <74020801+priti-ashvin-shah-ibm@users.noreply.github.com> Co-authored-by: Priti A Shah <Priti.Ashvin.Shah@ibm.com> * Create a new tag for pip release. (#802) Co-authored-by: Priti Shah <Priti.Ashvin.Shah@ibm.com> * Fixed the FakeJunctionGDS error this time for Issue 733 (#801) Co-authored-by: Priti Ashvin Shah <74020801+priti-ashvin-shah-ibm@users.noreply.github.com> * Optimize-performance (#803) * allow for using cached s_remove and s_keep; vectorize extract_energies() * initialize chi matrix with np.empty instead of list * cache c_k, c_inv_k, l_inv_k * no need to validate input for add_interaction since it's called internally * Add python 3.10 * Change python version from number to text Co-authored-by: Priti Ashvin Shah <74020801+priti-ashvin-shah-ibm@users.noreply.github.com> Co-authored-by: Samarth Hawaldar <47246334+SamarthH@users.noreply.github.com> Co-authored-by: Priti A Shah <Priti.Ashvin.Shah@ibm.com> Co-authored-by: Connor Bowman <58343812+bowmanconnor@users.noreply.github.com> Co-authored-by: Soham Bopardikar <bopardikarsoham@gmail.com> Co-authored-by: Yehan Liu <74025052+quantum-quant@users.noreply.github.com>
|
This work was done by @GyeonghunKim as part of QAMP. |
|
Regarding Qiskit Metal, when we are using the latest commit, the conda environment has python 3.10. When we add the dependencies for pyaedt i.e. PythonNet and PyVista, then generate a new conda env, the environment is python 3.9. This makes us believe PythonNet and PyVista have some code which is not python 3.10 compatible. This is just sharing of information; however, it would be ideal to not limit python version. |
|
We noticed pyaedt is not part of conda-forge. If we want to use that package, we would need to manually pip install. |
|
@GyeonghunKim Thank you for all of your help to get the repo to work with python 3.10. |
obrienpja
approved these changes
Aug 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the issues this pull addresses (issue numbers / links)?
#795 is mostly finished, however, we still need to add python 3.10 CI.
Did you add tests to cover your changes (yes/no)?
no
Did you update the documentation accordingly (yes/no)?
Yes
Did you read the CONTRIBUTING document (yes/no)?
yes
Summary
pyaedt has dependencies which limit python to 3.9. So we are holding off on merging this pull request for now.
Details and comments