-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
795 conda env python3 10 using updated tag from pyepr #796
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran notebook 4.02, and observed that you can segv sometimes when running save_screenshot() for pyEPR, but not the Metal GUI. I also ran 4.13, where the screenshots did not fail. I made Issue #799 to address this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, good job!
* 795 conda env python3 10 using updated tag from pyepr (#796) * Callable from collections is depreicated for python 3.10 so need to use collections.abc. * Add new tag for pyepr. * Update tags for new Metal pypi release. * Wait until Samarth s pull request is merged. * To make run_all_tests to pass. @GyeongHun had the fix. * Use later tag. * Implement Ability to Extract Q-factors from Eigenmode Simulations (#794) * Implement Ability to Extract Q-factors from Eigenmode Simulations * Updated tests * Added Tutorial * Revert "Updated tests" This reverts commit 146b0e9. Tests would be restored to the one in main. * When one plot_convergences(), then the frequiences are gathered so they gotten by get_frequencies(). * Removed solution_type variable. Replaced by pyEPR implementation * Updated tests Co-authored-by: Priti Ashvin Shah <74020801+priti-ashvin-shah-ibm@users.noreply.github.com> Co-authored-by: Priti A Shah <Priti.Ashvin.Shah@ibm.com> * Create a new tag for pip release. (#802) Co-authored-by: Priti Shah <Priti.Ashvin.Shah@ibm.com> * Fixed the FakeJunctionGDS error this time for Issue 733 (#801) Co-authored-by: Priti Ashvin Shah <74020801+priti-ashvin-shah-ibm@users.noreply.github.com> * Optimize-performance (#803) * allow for using cached s_remove and s_keep; vectorize extract_energies() * initialize chi matrix with np.empty instead of list * cache c_k, c_inv_k, l_inv_k * no need to validate input for add_interaction since it's called internally * Add python 3.10 * Change python version from number to text Co-authored-by: Priti Ashvin Shah <74020801+priti-ashvin-shah-ibm@users.noreply.github.com> Co-authored-by: Samarth Hawaldar <47246334+SamarthH@users.noreply.github.com> Co-authored-by: Priti A Shah <Priti.Ashvin.Shah@ibm.com> Co-authored-by: Connor Bowman <58343812+bowmanconnor@users.noreply.github.com> Co-authored-by: Soham Bopardikar <bopardikarsoham@gmail.com> Co-authored-by: Yehan Liu <74025052+quantum-quant@users.noreply.github.com>
* Callable from collections is depreicated for python 3.10 so need to use collections.abc. * Add new tag for pyepr. * Update tags for new Metal pypi release. * Wait until Samarth s pull request is merged. * To make run_all_tests to pass. @GyeongHun had the fix. * Use later tag. * Python 310 ci (#806) * 795 conda env python3 10 using updated tag from pyepr (#796) * Callable from collections is depreicated for python 3.10 so need to use collections.abc. * Add new tag for pyepr. * Update tags for new Metal pypi release. * Wait until Samarth s pull request is merged. * To make run_all_tests to pass. @GyeongHun had the fix. * Use later tag. * Implement Ability to Extract Q-factors from Eigenmode Simulations (#794) * Implement Ability to Extract Q-factors from Eigenmode Simulations * Updated tests * Added Tutorial * Revert "Updated tests" This reverts commit 146b0e9. Tests would be restored to the one in main. * When one plot_convergences(), then the frequiences are gathered so they gotten by get_frequencies(). * Removed solution_type variable. Replaced by pyEPR implementation * Updated tests Co-authored-by: Priti Ashvin Shah <74020801+priti-ashvin-shah-ibm@users.noreply.github.com> Co-authored-by: Priti A Shah <Priti.Ashvin.Shah@ibm.com> * Create a new tag for pip release. (#802) Co-authored-by: Priti Shah <Priti.Ashvin.Shah@ibm.com> * Fixed the FakeJunctionGDS error this time for Issue 733 (#801) Co-authored-by: Priti Ashvin Shah <74020801+priti-ashvin-shah-ibm@users.noreply.github.com> * Optimize-performance (#803) * allow for using cached s_remove and s_keep; vectorize extract_energies() * initialize chi matrix with np.empty instead of list * cache c_k, c_inv_k, l_inv_k * no need to validate input for add_interaction since it's called internally * Add python 3.10 * Change python version from number to text Co-authored-by: Priti Ashvin Shah <74020801+priti-ashvin-shah-ibm@users.noreply.github.com> Co-authored-by: Samarth Hawaldar <47246334+SamarthH@users.noreply.github.com> Co-authored-by: Priti A Shah <Priti.Ashvin.Shah@ibm.com> Co-authored-by: Connor Bowman <58343812+bowmanconnor@users.noreply.github.com> Co-authored-by: Soham Bopardikar <bopardikarsoham@gmail.com> Co-authored-by: Yehan Liu <74025052+quantum-quant@users.noreply.github.com> * Removing the outdated python version. * Test if sphinx is working now while we are doing a small pull request. * We want to use python 3.8 or higher. * We want to use python 3.9 or higher. * Use only python39 and python310 * Just in case for future. Co-authored-by: Gyeonghun Kim <34947229+GyeonghunKim@users.noreply.github.com> Co-authored-by: Samarth Hawaldar <47246334+SamarthH@users.noreply.github.com> Co-authored-by: Connor Bowman <58343812+bowmanconnor@users.noreply.github.com> Co-authored-by: Soham Bopardikar <bopardikarsoham@gmail.com> Co-authored-by: Yehan Liu <74025052+quantum-quant@users.noreply.github.com>
What are the issues this pull addresses (issue numbers / links)?
Since the conda env is now using python 3.10, need to get pyepr to use 3.10.
The pull request is using the latest tag on pyepr which works with python 3.10
Did you add tests to cover your changes (yes/no)?
no
Did you update the documentation accordingly (yes/no)?
no
Did you read the CONTRIBUTING document (yes/no)?
Summary
Details and comments