Don't reset mesh layer styling when changing data source for layer #45392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This breaks fixing mesh layer paths when restoring projects with broken mesh layers -- fixing the path causes the existing style to be lost. Fixes qgis#45391
|
@vcloarec mind taking a look at this one? |
PeterPetrik
approved these changes
Oct 5, 2021
|
give few time to look at. |
|
@nyalldawson I have make some changes on a PR to your branch |
|
@vcloarec thanks! I've pulled in your changes now |
|
oops, I forgot the sipify |
vcloarec
approved these changes
Oct 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This breaks fixing mesh layer paths when restoring projects with
broken mesh layers -- fixing the path causes the existing style
to be lost.
Fixes #45391