Global index #4
Merged
Global index #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyalldawson
reviewed
Oct 5, 2021
| @@ -1726,16 +1725,17 @@ bool QgsMeshLayer::setDataProvider( QString const &provider, const QgsDataProvid | |||
| mDataSource = mDataSource + QStringLiteral( "&uid=%1" ).arg( QUuid::createUuid().toString() ); | |||
| } | |||
|
|
|||
| if ( flags & QgsDataProvider::FlagLoadDefaultStyle ) | |||
There was a problem hiding this comment.
We still need to check FlagLoadDefaultStyle -- if it's true we should always reset the style
nyalldawson
approved these changes
Oct 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some changes to take account of the global index of dataset group instead of native index.
I remove the disconnect/connect because no need of them anymore: signal is emitted only if there are new extra dataset group added and only for this new groups.
Also fix the temporal properties when the layer source is break.