-
Notifications
You must be signed in to change notification settings - Fork 7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix incorrectly frozen BN on ResNet FPN backbone (#3396)
* Avoid freezing bn1 if all layers are trainable. * Remove misleading comments.
- Loading branch information
Showing
1 changed file
with
2 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eca37cf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't running stats still be updated if the full network moves to train() mode? Or are there other ways to fix that?
eca37cf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already replace the BN with frozen versions where the running stats are not updated:
vision/torchvision/models/detection/backbone_utils.py
Line 140 in eca37cf